NewPipe
NewPipe copied to clipboard
Update placeholder variants
What is it?
- [ ] Bugfix (user facing)
- [x] Feature (user facing)
- [ ] Codebase improvement (dev facing)
- [ ] Meta improvement to the project (dev facing)
Description of the changes in your PR
- Add two new placeholder thumbnail (hourglass_thumbnail and close_thumbnail).
- Replace placeholder_thumbnail_video with placeholder_thumbnail_hourglass.
- Show placeholder_thumbnail_off when cover URL is empty
Before/After Screenshots/Screen Record
Before | After hourglass | After close |
---|---|---|
Fixes the following issue(s)
- Fixes #9044
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence
- [x] I read the contribution guidelines.
They ignored the template section for linking the fixed issue. @HighGr0und You're not supposed to ignore provided templates.
I don't know whether this is a good addition. The new placeholders look very old-fashioned. We could try to use the three loading dots for the loading placeholders, but I'd prefer to keep the old placeholder in case of a failure.
I have changed the style of hourglass, should I use this or three loading dots
Please explain why you think we need multiple types of placeholder images. And explain use-cases for the various situations.
Please explain why you think we need multiple types of placeholder images. And explain use-cases for the various situations. I apologise for missing the issue that this PR relates to, it is specific to this issue: https://github.com/TeamNewPipe/NewPipe/issues/9044
See https://github.com/TeamNewPipe/NewPipe/issues/9044#issuecomment-1336504293. Also, I don't think the images proposed here fit into the app design and I don't think it's worth to spend time on this niche feature. Sorry for that and thank you for the contribution anyway!