NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Words are not available on Weblate.

Open Nizami20052022 opened this issue 2 years ago • 20 comments

Checklist

  • [X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • [X] I have read the FAQ and my problem isn't listed.
  • [X] I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • [X] I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • [X] This issue contains only one feature request.
  • [X] I have read and understood the contribution guidelines.

Feature description

The words that indicate when the video was released are in English

Why do you want this feature?

Screenshot_20221016-013416_NewPipe

Additional information

Look at the picture, the release date of the video is in English.

Nizami20052022 avatar Oct 15 '22 21:10 Nizami20052022

Which language do you want release date to be in? Probably not translated maybe you can help. To help translate type www.newpipe.net and click on translate then select language you can either create an account even with github or proceed without any account as well translate the text you can use automatic suggestions as well and suggest the change

killerrook avatar Oct 16 '22 00:10 killerrook

Since it is an open source software all contributors are users themselves. It will be nice to have some help in translation if you can

killerrook avatar Oct 16 '22 00:10 killerrook

Try this link instead https://hosted.weblate.org/engage/NewPipe/

killerrook avatar Oct 16 '22 05:10 killerrook

Thank you for translating NewPipe! The dates and times are generated using prettytime. You can find their translation files here. All translation of these components need to be done in their repository. You can find more information on how to add a new language to prettytime here and here.

TobiGr avatar Oct 16 '22 11:10 TobiGr

Thank you. It looks like you took the English translation and renamed the file. That means after your changes, there won't be an English localization. You should fix that in your PR :) (The PR is https://github.com/ocpsoft/prettytime/pull/240)

TobiGr avatar Oct 16 '22 13:10 TobiGr

Add the English file to your branch: https://github.com/ocpsoft/prettytime/blob/master/core/src/main/java/org/ocpsoft/prettytime/i18n/Resources_en.java

And make sure to use the correct file path for the Azerbaijan file. It should be /core/src/main/java/org/ocpsoft/prettytime/i18n/Resources_az.java

TobiGr avatar Oct 16 '22 13:10 TobiGr

I just created a new file. Is the file correct? Turkish language was added a long time ago.😁

ghost avatar Oct 16 '22 14:10 ghost

Shall I close this issue?

ghost avatar Oct 16 '22 16:10 ghost

Yes, thanks.

TobiGr avatar Oct 16 '22 16:10 TobiGr

The translation file has been merged, you need to add it

ghost avatar Oct 27 '22 17:10 ghost

https://www.ocpsoft.org/prettytime/#section-13

ghost avatar Oct 27 '22 17:10 ghost

Big thank you to you to all NewPipe contributors who contributed to the localization update of prettytime! We'll just need to update prettytime, the rest is done by NewPipe automatically. The update is not available on maven yet. I'll update it once the new version is available.

TobiGr avatar Oct 27 '22 20:10 TobiGr

Will this issue not be resolved?

Have a problem?

ghost avatar Oct 28 '22 16:10 ghost

Why don't you add?

ghost avatar Oct 30 '22 20:10 ghost

There was no problem anymore.

ghost avatar Oct 30 '22 20:10 ghost

This will be added once the new update is live

killerrook avatar Oct 30 '22 22:10 killerrook

PrettyTime has some problems with the latest replease. It's still not completely published on maven central https://github.com/ocpsoft/prettytime/issues/248

TobiGr avatar Oct 31 '22 10:10 TobiGr

No more problems

ghost avatar Nov 01 '22 16:11 ghost

See #9272

TobiGr avatar Nov 01 '22 18:11 TobiGr

Thank you very much!🤗

ghost avatar Nov 01 '22 18:11 ghost