NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Different font style for unwatched videos

Open MatsG23 opened this issue 2 years ago • 15 comments

Checklist

  • [X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • [X] I have read the FAQ and my problem isn't listed.
  • [X] I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • [X] I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • [X] This issue contains only one feature request.
  • [X] I have read and understood the contribution guidelines.

Feature description

In the news list: If an video has not been watched yet, show its title in a bolder font style.

Why do you want this feature?

This feature makes it easier to distinguish between watched and unwatched videos.

Additional information

No response

MatsG23 avatar Sep 17 '22 14:09 MatsG23

Would be nice to have the ability to "Mark all as watched" instead of just "Mark as watched" for a single video too. Once you refresh subscriptions you lose the current format for unwatched videos which is a dashed line.

ctgcwiqc avatar Sep 27 '22 14:09 ctgcwiqc

+1 justification;

Change display to ITALIC if has been watched.

CNN difficult to tell if watched!

CNN-newpipe

ChiefMikeK avatar Sep 29 '22 13:09 ChiefMikeK

Hello! Could I work on this :) ?

Dylan-Turner avatar Oct 11 '22 00:10 Dylan-Turner

@Dylan-Turner Sure! Before doing anything though, could you explain how you would like to do this?

opusforlife2 avatar Oct 12 '22 17:10 opusforlife2

Thanks @opusforlife2!

I'm planning to make some very small edits to the StreamMiniInfoItemHolder.java class which applies the red watched bar so that when the watched bar is applied the text is also italicized as suggested by CheifMikeK. To satisfy the original request by MatsG23 in the case the video hasn't been watched it will be displayed in bold (also by editing this class). This should keep it's application consistent with when the watched bar is displayed.

I wasn't sure if the bold was overkill, so here are some examples with only italics: image image

And here is an example with both bold and italic (the first video is watched): image

Do you have any feedback?

Dylan-Turner avatar Oct 15 '22 05:10 Dylan-Turner

In my opinion, bold and italic font is an overkill. All I wanted to achieve with this issue is a distinction between watched and not watched videos, so italic or bold would suffice. I think only bold font for not watched videos would be ok. Could you provide an screenshot only with bold font style too?

MatsG23 avatar Oct 15 '22 08:10 MatsG23

Here's the version with only bold (for not unwatched videos) image

In my opinion this seems like the clearest option, what do you think?

Dylan-Turner avatar Oct 17 '22 07:10 Dylan-Turner

In other apps , items that are 'dealt with' are greyed out. Maybe the text could be greyed out for the fully watched videos? And the incomplete red progress bar would be enough for partially watched ones? Then we don't need to do anything to unwatched videos.

Edit: the italics font looks really weird, and the bold one isn't much better.

opusforlife2 avatar Oct 21 '22 22:10 opusforlife2

I don't understand what's wrong with the current implementation. Red status bar is all YouTube app has. I use the "what's new" tab for subscription videos and filter for unwatched there. Only thing I wish there was is a "Mark all as watched" option.

On October 21, 2022 5:11:12 PM CDT, opusforlife2 @.***> wrote:

In other apps , items that are 'dealt with' are greyed out. Maybe the text could be greyed out for the fully watched videos? And the incomplete red progress bar would be enough for partially watched ones? Then we don't need to do anything to unwatched videos.

-- Reply to this email directly or view it on GitHub: https://github.com/TeamNewPipe/NewPipe/issues/8988#issuecomment-1287485215 You are receiving this because you commented.

Message ID: @.***>

ctgcwiqc avatar Oct 21 '22 23:10 ctgcwiqc

Thanks for the feedback. Here's an example with greyed text, I'm thinking it could be an accessibility issue if it is too faint a colour though. image

In response to @ctgcwiqc I think the issue is with videos that have the red border / background, it's a little bit hard to spot the watched bar?

Dylan-Turner avatar Oct 22 '22 03:10 Dylan-Turner

Agreed.

On October 21, 2022 10:04:09 PM CDT, Dylan @.***> wrote:

Thanks for the feedback. Here's an example with greyed text, I'm thinking it could be an accessibility issue if it is too faint a colour though. image

In response to @ctgcwiqc I think the issue is with videos that have the red border / background, it's a little bit hard to spot the watched bar?

-- Reply to this email directly or view it on GitHub: https://github.com/TeamNewPipe/NewPipe/issues/8988#issuecomment-1287595222 You are receiving this because you were mentioned.

Message ID: @.***>

ctgcwiqc avatar Oct 22 '22 03:10 ctgcwiqc

I'm thinking it could be an accessibility issue if it is too faint a colour though.

What could be an accessibility-enabled alternative?

opusforlife2 avatar Oct 22 '22 14:10 opusforlife2

What could be an accessibility-enabled alternative?

How about an eye icon next to watched videos? There's no need to worry about people with visual impairments since it is an icon.

I also think this should be a toggle-able item.

cern1710 avatar Oct 29 '22 16:10 cern1710

I think that's a good idea for the icon. Would you want it as a small overlay on the video, like how the time is done, but in the top left corner or would you prefer in with the text? I think if it's in with the text it might be a bit hard to distinguish / look a bit crowded? Maybe it could go next to the "1 day ago" text as this is fairly small and not invasive to users that don't really want the feature?

I don't really know how to make it toggle-able but maybe someone could add that?

Dylan-Turner avatar Oct 29 '22 23:10 Dylan-Turner

Maybe it could go next to the "1 day ago" text as this is fairly small and not invasive to users that don't really want the feature?

Sounds neat.

opusforlife2 avatar Oct 29 '22 23:10 opusforlife2