NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Use TextViewCompat.setCompoundDrawableTintList().

Open Isira-Seneviratne opened this issue 2 years ago • 8 comments

What is it?

  • [ ] Bugfix (user facing)
  • [ ] Feature (user facing)
  • [x] Codebase improvement (dev facing)
  • [ ] Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use TextViewCompat.setCompoundDrawableTintList().

Fixes the following issue(s)

  • Fixes #

Relies on the following changes

  • #8768

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Isira-Seneviratne avatar Jul 19 '22 01:07 Isira-Seneviratne

This has been marked as a draft as AppCompat 1.5.0 is still in beta.

Isira-Seneviratne avatar Jul 19 '22 01:07 Isira-Seneviratne

I like the change, but I think it's far too early for it. The compileSdk change seems completely unrelated (unless the library beta requires it), and it includes a core library bumped to a beta version (AppCompat). I'd wait until AppCompat 1.5.0 is stable before doing this, imo.

TacoTheDank avatar Jul 19 '22 02:07 TacoTheDank

I like the change, but I think it's far too early for it. The compileSdk change seems completely unrelated (unless the library beta requires it),

Yeah, the library requires it.

and it includes a core library bumped to a beta version (AppCompat). I'd wait until AppCompat 1.5.0 is stable before doing this, imo.

That's why I marked it as a draft for now. I'll update once AppCompat 1.5.0 is stable.

Isira-Seneviratne avatar Jul 19 '22 02:07 Isira-Seneviratne

The compileSdk change seems completely unrelated

Yeah, that needs to be done in a separate PR, along with making sure nothing is broken

Stypox avatar Aug 04 '22 14:08 Stypox

CI was stuck on "Set up JDK 11" for 3+ hours. I cancelled and reran it.

opusforlife2 avatar Aug 13 '22 07:08 opusforlife2

Ok, now 1.5.1 is stable. Could you update to it, please? Then it'd be cool if @TacoTheDank could take a look, before merging.

Stypox avatar Oct 30 '22 20:10 Stypox