NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Play queue persistency

Open igorcafe opened this issue 2 years ago • 10 comments

Checklist

  • [X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • [X] I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • [X] I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • [X] This issue contains only one feature request.
  • [X] I have read and understood the contribution guidelines.

Feature description

NewPipe could store my play queue on persistent storage when it is created and changed.

Why do you want this feature?

Use cases

1. NewPipe crashed

Let's say I enqueued 30 videos or so.

If NewPipe crashes, I just lose everything and I won't remember all the 30 videos I wanted to watch/listen to.

2. For any reason, I killed the app

If I accidently killed the app, or I didn't know killing the app would erase my queue, or maybe my device rebooted. Loosing the play queue would be very unpleasant.

Additional information

Just to be clear I'm talking about this feature and not about regular playlists:

igorcafe avatar May 04 '22 17:05 igorcafe

Duplicate of https://github.com/TeamNewPipe/NewPipe/issues/5238

SameenAhnaf avatar May 04 '22 18:05 SameenAhnaf

This is actually a duplicate of #4335 as it is mentioned as a prerequisite for that feature, but it is worth implementing on its own as well. I would keep this open.

opusforlife2 avatar May 05 '22 20:05 opusforlife2

@SameenAhnaf I think in essence it is the same request.

From #5238:

Every time the playing queue changes i.e. a playlist is played, the previous one would be added to the history.

I don't know if storing the history of every push to the queue would make that much sense. For me, the most essential is to persist the last state of the play queue.

igorcafe avatar May 06 '22 14:05 igorcafe

I think its closer to what @opusforlife2 described on his issue.

igorcafe avatar May 06 '22 14:05 igorcafe

It would be helpful if this feature was implemented to not only retain the queue but also to simply add verification before closing a queue with multiple videos, to avoid any accidental closing of it.

AinulAbir avatar May 17 '22 16:05 AinulAbir

verification before closing a queue with multiple videos, to avoid any accidental closing of it.

@AinulAbir It's the last toggle in video and audio settings.

opusforlife2 avatar Jun 09 '22 21:06 opusforlife2

verification before closing a queue with multiple videos, to avoid any accidental closing of it.

@AinulAbir It's the last toggle in video and audio settings.

I just played a video, swiped it down to minimize it, enqueued another couple videos, and then closed the player window via the 'X' button. I got no verification prompt. Where's my queue now?

PacoBell avatar Jul 16 '22 07:07 PacoBell

If you're tapping the X button - the button that is meant to close the play queue - of course the queue will be closed. That toggle I mentioned is to guard against an action that the user wouldn't expect to affect the existing queue.

opusforlife2 avatar Jul 17 '22 17:07 opusforlife2

Okay, granted, but that button is REALLY easy to accidentally press, especially when the UI is lagging for whatever reason. I would definitely appreciate an (even optional) "are you sure?" check if there's enqueued videos. The lack of guard rails right now is a mine field.

PacoBell avatar Jul 18 '22 08:07 PacoBell

Hmmm. The app should confirm play queue clearing/deletion no matter the path taken to get to that point.

opusforlife2 avatar Jul 25 '22 04:07 opusforlife2