NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

TV Fullscreen error when clicking recommended videos

Open wifislow opened this issue 4 years ago • 5 comments

Checklist

  • [x] I am using the latest version - 0.21.13
  • [x] I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
  • [x] I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
  • [x] This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

  1. Open sideloaded NewPipe app on Android TV.
  2. Go to settings>video and audio and enable "Start main player in fullscreen".
  3. Search and click on any video, the first video played will play in fullscreen mode no problem.
  4. Exit out of fullscreen mode (using TV remotes back button) and click on any of the recommended videos.
  5. "Unrecoverable player error" occurs and video doesn't open in fullscreen.

Actual behavior

Selecting recommended videos causes "Unrecoverable player error" and video doesn't open in fullscreen.

Expected behavior

Selecting recommended videos should open videos in fullscreen like it does when you search for and click on a video.

Screenshots/Screen recordings

Logs

Device info

  • Android version/Custom ROM version: Android 9 Pie (android version irrelevant)
  • Device model: Sony BRAVIA Android TV (model irrelevant)

This can be replicated on any android device just enable "Start main player in fullscreen" and click on any recommended video. PR introducing "Start main player in fullscreen" setting: https://github.com/TeamNewPipe/NewPipe/pull/5459 Potentially related fix PR: https://github.com/TeamNewPipe/NewPipe/pull/6895

wifislow avatar Dec 05 '21 13:12 wifislow

Issue occurs on phones/tablet tested, running NewPipe 0.21.15. Issue doesnt occur when fullscreen toggle is off in settings, fullscreen issues seem to be connected.

ghost avatar Jan 31 '22 00:01 ghost

This error still persists :-/

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: US
  • Content Language: es-US
  • App Language: es_US
  • Service: none
  • Version: 0.23.3
  • OS: Linux Android 9 - 28
Crash log

java.lang.RuntimeException: Unable to start service org.schabi.newpipe.player.MainPlayer@41c2b29 with Intent { cmp=org.schabi.newpipe/.player.MainPlayer (has extras) }: java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.Context org.schabi.newpipe.player.Player.getContext()' on a null object reference at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:3721) at android.app.ActivityThread.access$1600(ActivityThread.java:200) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1688) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loop(Looper.java:193) at android.app.ActivityThread.main(ActivityThread.java:6744) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:539) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858) Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.Context org.schabi.newpipe.player.Player.getContext()' on a null object reference at org.schabi.newpipe.player.NotificationUtil.createNotification(NotificationUtil.java:92) at org.schabi.newpipe.player.NotificationUtil.createNotificationAndStartForeground(NotificationUtil.java:179) at org.schabi.newpipe.player.MainPlayer.onStartCommand(MainPlayer.java:126) at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:3702) ... 8 more

marcostux06 avatar Sep 01 '22 01:09 marcostux06

@marcostux06 You've posted the same crash report on 2 issues. Do you get this using the steps posted in the issue description? Does the crash vanish if you toggle off "Start player in fullscreen"?

opusforlife2 avatar Sep 01 '22 18:09 opusforlife2

@marcostux06 You've posted the same crash report on 2 issues. Do you get this using the steps posted in the issue description? Does the crash vanish if you toggle off "Start player in fullscreen"?

No, sorry, the crash continues

marcostux06 avatar Sep 03 '22 00:09 marcostux06

@marcostux06 Then your comments are off-topic here. Hiding.

opusforlife2 avatar Sep 03 '22 16:09 opusforlife2

Is it still an issue on 0.26.1?

ShareASmile avatar Feb 17 '24 16:02 ShareASmile

Is it still an issue on 0.26.1?

Yes, that has been solved, the error that still persists is when you want to put any video you are watching in full screen, this only happens on Android TV.

marcostux06 avatar Feb 17 '24 22:02 marcostux06