NewPipe
NewPipe copied to clipboard
TeamNewPipe
Add SUBSCRIBE button next to channel name while watching a video.
Checklist
- [x] I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
- [x] I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
- [x] This issue contains only one feature request. I will open one issue for every feature I want to request.
What feature do you want?
Add a subscribe button next to the channel name while watching a video like youtube does it.
NewPipe UI
YouTube UI
Why do you want this feature?
It will be easier to subscribe a channel while watching their content without opening the channel. Right now you have to open their channel to subscribe.
How does this look?
If there are more likes than dislikes,
And if there are more dislikes,
I think this UI would confuse people
I have created this ui that i think will be easier to read. What do you think?
Yes that's much better
On Wed, 20 Oct 2021, 3:46 pm Qaiser, @.***> wrote:
I think this UI would confuse people
I have created this ui that i think will be easier to read. Tell me what do you think? [image: 20211020_201335] https://user-images.githubusercontent.com/89571992/138115821-4b5812f7-bb4e-4883-88b2-d86f5f78b7f0.jpg
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TeamNewPipe/NewPipe/issues/7277#issuecomment-947740518, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ5XXOBSCRKMS2Y7OJP77PDUH3I25ANCNFSM5GIHLONA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Hi, I would like to work on this. Could someone please point me in the right direction as to which classes/xml files this would be associated with. Thank you :)
The texts should not be so clumped, but at the same time I don't think that that layout should use up more vertical space as it is already using up much.
My idea was to keep views and likes where they are and put the button in between the uploader and the views & likes. But this wouldn't work either, since on small screens and with long channel names you would get a really small space left for the actual channel name:
Another idea was to use an icon instead of text, in the same place, but there do not seem to be any material icon that would be understandable.
My proposal:
Default state [the user is not subscribed yet]
Already subscribed state [when clicked, the user unsubscribes]
Let me know what you think.
... not a bad idea, actually. Instead of 5 buttons, though, we could just shift the 'Add To' button down into the 2nd row of buttons.
5-button way is actually common. YouTube itself uses 5-button way in its bottom bar. Facebook went even for 6-button for its navigation. And as Stypox said, more vertical space won't be a good idea, and I totally agree.
We already have space for 2 more buttons in the 2nd row. And 5 buttons start to crowd each other on small (4.7") screens.
Correct me if I'm wrong, but I see that we only have 2 rows; the 1st with the channel name, likes, and views, the 2nd with the dowload, popup, etc. If you meant adding buttons to the 1st, well I don't think it's a good idea since the added buttons could cover the channel's name even more.
Tap the video title, which you'll notice has a down arrow at the right.
I like the idea, and I think, as Opus said, that the button should go in the second hidden-by-default row of buttons (subscribing is a pretty rare action)
I think Opus suggested moving "Add To" button to the 2nd row as it's not as primary as "Subscribe" button. I think subscribing is the Call-To-Action in Youtube, that's why it's colored red, So I don't think it's rare, but the total opposite.
I do not agree but it's not so important, so let's move "Add to playlist" below and put "Subscribe" in the first row