NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

implement ability to ignore back-queue for main view

Open newhinton opened this issue 3 years ago • 12 comments

What is it?

  • [ ] Bugfix (user facing)
  • [x] Feature (user facing)
  • [ ] Codebase improvement (dev facing)
  • [ ] Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Add Setting (under history) to allow the main view to ignore the backstack of videos. Instead of going back to the last video, the player minimizes. This is NOT the default behavior, when no changes are made, the queue is still used.

Fixes the following issue(s)

  • Fixes #4479

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

newhinton avatar Oct 18 '21 12:10 newhinton

This should probably beeing closed in favor of https://github.com/TeamNewPipe/NewPipe/pull/6895/

newhinton avatar Oct 18 '21 13:10 newhinton

This should probably beeing closed in favor of #6895

no i think this good idea... i would like to go back through the queue using the back button, however by implementing your idea, i gain the ability to minimize the player after queue is completed which is the behavior i prefer at this point.

so yes I think both PRs should be implemented as everyone of them has its unique usages

MD77MD avatar Oct 24 '21 21:10 MD77MD

@newhinton

https://github.com/TeamNewPipe/NewPipe/commit/7d96c050d6c8f2635293a873c94d00959862c137

Agree

avently avatar Nov 01 '21 21:11 avently

This PR and #6895 should be merged into a single PR, since we don't want to create two different settings options for the same thing. @avently could you port the back-behavior from this PR into #6895?

Stypox avatar Nov 13 '21 19:11 Stypox

The functionality in this PR is already available in #6895. It is basically a duplicate.

newhinton avatar Nov 13 '21 20:11 newhinton

@Stypox yep, this functionality is already available in my PR, nothing to add

avently avatar Nov 14 '21 03:11 avently

Can this be made default for Android TV?

opusforlife2 avatar Aug 13 '22 18:08 opusforlife2

Can this be made default for Android TV?

I guess DeviceUtils.isTv(activity) can be used to override the default value, for the videofragment that is simple. For the settings, i am not sure, i will have to look into the settings more precise, because currently the defaults are set by the layoutfile itself.

newhinton avatar Aug 13 '22 18:08 newhinton

I made it default for tv's. However, displaying the correct state in the settings is really not that great, but i dont see any other way to do it.

newhinton avatar Aug 13 '22 22:08 newhinton

@opusforlife2 @Stypox Any news on this? It's a rather simple PR and would add a highly requested feature.

newhinton avatar Oct 16 '22 15:10 newhinton

@newhinton I like the idea. We need for someone to have the time to review this. Meanwhile, please fix any merge conflicts.

opusforlife2 avatar Oct 21 '22 22:10 opusforlife2

I have resolved the conflict.

newhinton avatar Nov 01 '22 18:11 newhinton

This would be really useful for navigating TVs, do you have a debug apk?

bazipn avatar Dec 04 '22 13:12 bazipn

app-debug.zip

@bazipn I build one.

newhinton avatar Dec 05 '22 13:12 newhinton

Is this still active or not?

This functionality is important to me on both my TV and phone UI, as well as many other people evident from looking at the issues about this.