Always show the full screen button

[nbmrjuhneibkr]

Checklist

• [x] I checked, but didn't find any duplicates of this issue in the repo.
• [x] I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• [x] This issue contains only one feature request. I will open one issue for every feature I want to request.

Describe the feature you want

In v0.20, full screen button is hidden when automatic screen rotation is enabled in the OS.
The button should always be accessible, regardless of the system settings.

Is your feature request related to a problem? Please describe it

When the device lies on any flat surface and auto-rotate is enabled in the OS, there is no way to play videos in full screen mode without picking the device up to trigger the sensor, or disabling auto-rotate.

How will you/everyone benefit from this feature?

A user may want to watch videos without picking the device up. Disabling auto-rotation globally is not an acceptable solution.

Additional context

When combined with the manual video rotation control (which should also be restored), this will restore all manual controls that were available in NewPipe before the 0.20 update.

[avently]

I disagree with the issue. Your example with flat surface is like "I need to say something related to the issue". I can agree with some of your arguments related to fullscreen button in case of locked orientation but not unlocked. Whenever I see disappeared fullscreen button it is a sign of enabled autorotation. And I'm 100% sure that I can rotate the device and get whatever orientation I want. With always shown button I need to use it or always look at status bar's panel (which is not an option on android 4.4 because the autorotation button isn't present there). This is something I know usefulness of.

[nbmrjuhneibkr]

I disagree with your disagreement. Your responses often look like "I need to find a reason to dismiss this issue".

Sometimes I keep my phone on a table and play YouTube videos on it while doing work. I didn't have to pick up the phone to change the orientation before v0.20. Please stop forcing your personal usage scenarios on everyone else.

With always shown button I need to use it or always look at status bar's panel (which is not an option on android 4.4 because the autorotation button isn't present there).

Then why not have two slightly different icons for the button? This is an easy fix.

[avently]

@nbmrjuhneibkr

Please stop forcing your personal usage scenarios on everyone else.

Please stop saying what I should do and I will not say where you need to go.

[nbmrjuhneibkr]

I'm only mentioning things that have direct impact on the app and the way people use it.

and I will not say where you need to go.

And it looks like you're one step away from taking the route of personal attacks.

Anyway, back to the issue. If someone is going implement this while addressing the "how do I know if auto-rotate is enabled" thing, my idea would be to have a normal full screen button when it's disabled, and the button with added circular arrows either on the outside or on the inside when it's enabled.

[avently]

@nbmrjuhneibkr

And it looks like you're one step away from taking the route of personal attacks.

It looks like you like to call things in other words which aren't near truth. Even now you provoking.

I'm not interested in talking about people when developing the app. It's counterproductive. Instead I prefer to talk about real app's issues. So if you like this correct route we can follow it.

[nbmrjuhneibkr]

While @avently was busy writing a comment about the interest (or lack thereof) in talking about people, I came up with an easier solution for https://github.com/TeamNewPipe/NewPipe/issues/4478#issuecomment-706611050
Instead of designing new icon for the full screen button, just change the color of the button when auto-rotation is enabled. Simple.

[hipunk]

"I", "I", "I"... Does this guy talk about anything else than himself or what he thinks? Isn't this a community project of more than 500 contributors? Why is avently allowed to remove so many features when he's this clueless about smartphones? (e.g. #4414: never heard of GPRS. Doesn't know multiple WiFis might have different throughput. Thinks android phones have tablet UIs. Confuses accessibility settings with build.prop DPI flags. Thinks every device in the world is held using hands and can be rotated. Makes fun of the concept of reducing traffic, although it increases battery runtime like almost nothing else in a smartphone)

How is one single person allowed to introduce so much breakage? Let me rephrase: Avently is deleting functional, proven and real world tested work of others! Stop him already! 0.20.0 is unusable, yes, useless, on a Samsung Galaxy S4. He said we can blame him because he is responsible. Here is the blaming, stop breaking stuff for no gains, avently.

[avently]

@hipunk how old are you?

[hipunk]

@hipunk how old are you?

[avently]

@hipunk how old are you?

Your code sucks. Bitch, eat shit and die.

Thanks, I know more than needed :stuck_out_tongue_closed_eyes:

This provocateur is done.

[hipunk]

Sorry, that was too harsh from me. However... you know. I mean it, but not in a rude way.

Have fun! That's all that matters.

[nbmrjuhneibkr]

@avently

how old are you?

This provocateur is done.

I thought we were going to stop talking about people here...

Here's another reason for implementing this (or rather fixing, since this wasn't an issue before 0.20), if I haven't given enough reasons already: feature parity with the official YouTube app. This feature is present there, probably for the same exact reason as the one I mentioned. NewPipe losing features that are present in the official client is not a step in the right direction.

[avently]

@nbmrjuhneibkr

feature parity with the official YouTube app

I'm not interested in feature-parity with YouTube app. This can't be a goal. YouTube app doing something great and something bad. In this case showing a button to rotate orientation when it's unlocked globally is bad behavior because if a user chose to autorotate his screen's orientation it means he likes this behaviour. Forcing rotation by a button it's a step in a wrong direction in this case.

[nbmrjuhneibkr]

YouTube app doing something great and something bad.

This feature adds more choice and doesn't break anything. Definitely not a "bad" feature. Better than some that have been implemented, arguably.

if a user chose to autorotate his screen's orientation it means he likes this behaviour

As I already said, auto-rotation doesn't work in a use case described in this issue, but user may still want to keep it enabled globally for other use cases. There should be a manual override for this in the app.

Forcing rotation by a button it's a step in a wrong direction in this case.

The app isn't forcing anything, the user does. This is user choice that doesn't exist anymore in v0.20. Removal of this feature didn't make NewPipe more useful, that's for sure.

[stnby]

Omg please keep the full screen button rotating screen doesn't even put it in full screen this is so annoying.

[opusforlife2]

Reply to https://github.com/TeamNewPipe/NewPipe/issues/4500#issuecomment-709545368

@avently I suspect there may be a strong overlap between users who want the full screen button even with unlocked rotation, and users who want automatic full screen on tapping the thumbnail. So we should wait for more information.

[avently]

@opusforlife2 what information you want to get?

[opusforlife2]

If everyone involved is satisfied with automatic full screen behaviour then we won't need this feature anyway. If not, it could be discussed further.

[nbmrjuhneibkr]

I don't see how automatic full screen player could be a replacement for this feature request.

https://github.com/TeamNewPipe/NewPipe/issues/4152 aims to restore (as an option, I think) v0.19 behavior where videos played only in full screen, while this issue is about expanding current behavior of the player by displaying the full screen button (perhaps a slightly different-looking - https://github.com/TeamNewPipe/NewPipe/issues/4478#issuecomment-706626385 ) when automatic screen rotation is enabled in the OS.

[nahuhh]

Gotta agree with op.. Need to force rotation.

I want my videos to STAY in landscape, not flip to portrait when I move

Seems like it was more work than it was worth to make the icon hide based on the device orientation toggle..

Thanks. Been using the app for years and it's great. The new ui looks good and I like the direction. But it's not usable.

Background play and current queue management is pretty much gone? (Compared to older versions) Old version was a solid "1.1" This feels like a super alpha pre2.0 release.

[nbmrjuhneibkr]

force rotation

That's a different issue: https://github.com/TeamNewPipe/NewPipe/issues/4500

And maybe also related to this, depending on personal preference: https://github.com/TeamNewPipe/NewPipe/issues/4152

This one is only about the full screen button (which doesn't necessarily lead to video rotation) currently being hidden when auto-rotation is enabled in the OS.

[iamthesenate1]

I think this should be an optional setting, not enabled by default (becouse it looks like some users don't agree), but the ones who want it be able to enable it. After all I think that having the choice is the important thing here

[nbmrjuhneibkr]

After all I think that having the choice is the important thing here

I feel that removing as much choice as possible and leaving users with only one "correct" way to use NewPipe was one of the main goals of v0.20 development, sadly.

[triallax]

I want to work on this, but it's been suggested that I should ask for people's opinions through a poll first, so here I am. Vote by reacting with the emoji beside the option you vote for (e.g. :tada: for 2). If I forgot any option, feel free to make a comment.

1. :+1: Always show the full screen button (without option to disable this)
2. :tada: Hide when auto-rotation is enabled, which is the current behavior (also without an option to disable this)
3. Add an option to choose between the two behaviors
   1. :heart: Make 1 the default option
   2. :eyes: Make 2 the default option

Somewhat related: @Redirion suggested creating a "fullscreen control" setting, which in addition to the previous options has an "always play videos in fullscreen" option. The only issue I see with this idea though is that that option is not mutually exclusive with the others (e.g. if you leave fullscreen while auto-rotation is enabled, which behavior do we assume?).

@TobiGr @opusforlife2 @B0pol @TiA4f8R @vkay94 @TacoTheDank @XiangRongLin @MD77MD @s1awek @shivasagarrao @wilzbach @T5000 @Bruceforce @ShareASmile @89z @thinsoldier @atmosfar @SameenAhnaf

Note: if you don't want to be mentioned by polls in the future, please react with :rocket:.

[Bruceforce]

STOP SPAMMING THE THREAD. this is the third time I've gotten an email for a dumb vote request.

Just make a comment and people will see it if they are subscribed. Don't at mention every single person in the thread.

Why don't you just react with the 🚀 emoji then like suggested in the notes? At least you currently have not done so in this thread.

[triallax]

@89z I apologize for this. Although I gave the option to react with :rocket: to not get mentioned in the future, I understand your frustration. Again, I'm sorry.

[avently]

@mhmdanas i don't think it's a good idea to base developer's decision on a poll. people that like how things work are not on github issues. so you'll get wrong results just because 99% of users are never be here and they like current behavior

[SameenAhnaf]

@avently If I am not wrong, polls need to be properly translated to get everyone's opinions. Only English users don't use it. Only Polish users don't use it. I wonder if that is possible as new users of unpopular languages are also coming.

Many behaviours like "Unified player", "Directly enter full screen", "Directly exit full screen" etc. were current behaviours of the past and ditched without users' opinions. At least, a good alternative should have been introduced. We never know others' needs. Developers will be able to give proper alternatives at least in most cases.

If any user misunderstands a topic or hardly uses any feature, that will create inaccuracies in poll results. Many users may not want to attend polls at all.

Most developers are at least conscious about the app and give proper statements. So, taking only developers' opinions is not a bad idea, I think. At least, they know what they are doing.

If you still want to add polls for users, that could be done too. Three more options in "Polls" section could be added in settings, "Notify me for all (English available)", "Notify me for selected languages" and "Notify me for selected settings".

Still, developers-only polls could be added to get an estimated result. As expected, all users may not be able to attend polls on the same day. But developers will be able to give a quick results preview especially on complicated codes.

[triallax]

@avently I'm aware of that, but it's at least better than going with one's own opinion only.

[avently]

@mhmdanas probably nobody likes how whatsapp works: account per device, inability to "easy" restore messages into another device, phone number-only connection with other users. But it's the most used messenger. Same with devices from Apple. I mean in some situations users can share their use-case you unaware of, it helps to find a solution for their problems. But in this situation it's counterproductive. Autorotation is an OS mechanism and it's a preferred way to use it like used here: if autorotation enabled hide fullscreen button otherwise show.