NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

UPDATE: Replace 2k and 2K with 2.5k and 2.5K to fix common mistake

Open guymarshall opened this issue 1 month ago • 3 comments

What is it?

  • [ ] Bugfix (user facing)
  • [ ] Feature (user facing) ⚠️ Your PR must target the refactor branch
  • [ ] Codebase improvement (dev facing)
  • [ ] Meta improvement to the project (dev facing)
  • [x] Typo correction

Description of the changes in your PR

  • replace "2k" with "2.5k" and "2K" with "2.5K" to fix common mistake
  • The "k" in a resolution is a rough estimation of the longest dimension e.g. 5k is 51202880, 4k is 38402160, 2.5k is 25601440, 2k is 19201080 and so on. There is a common misconception that 2560*1440 or 1440p is actually 2k but it isn't.

Before/After Screenshots/Screen Record

  • Before:
  • After:

Due diligence

guymarshall avatar Dec 02 '25 20:12 guymarshall

hm. displaying 2.5K might irritate the users. I think we should check in the extractor if we can find streams with the correct resolution. It makes no sense to me to use resolution descriptions that are different from the ones the services use.

TobiGr avatar Dec 03 '25 14:12 TobiGr

Good points. Maybe we label it as 1440p like on the desktop website? Screenshot from 2025-12-03 17-56-45

guymarshall avatar Dec 03 '25 17:12 guymarshall

Sounds good

TobiGr avatar Dec 05 '25 13:12 TobiGr