NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Add enqueue option to router dialog

Open HatakeKakashri opened this issue 2 months ago • 2 comments

What is it?

  • [ ] Bugfix (user facing)
  • [x] Feature (user facing) ⚠️ Your PR must target the refactor branch
  • [ ] Codebase improvement (dev facing)
  • [ ] Meta improvement to the project (dev facing)

Description of the changes in your PR

  • This allows users to enqueue a stream directly to the current player queue when sharing a link with the app, improving the user experience for queue management.
  • The 'Enqueue' option is now available in the action selection dialog and can also be set as the preferred open action in the settings.

Before/After Screenshots/Screen Record

Fixes the following issue(s)

  • Fixes #4779

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

HatakeKakashri avatar Nov 19 '25 17:11 HatakeKakashri

Please add screenshots/recordings to demonstrate the functionality that this PR adds, and reference the issue that this PR fixes

absurdlylongusername avatar Nov 20 '25 06:11 absurdlylongusername

Please add screenshots/recordings to demonstrate the functionality that this PR adds, and reference the issue that this PR fixes

This is done

HatakeKakashri avatar Nov 21 '25 03:11 HatakeKakashri

Hello and thank you for the PR. I added a commit to check that there is a queue to which the user can enqueue items. I also made the enqueue option available when sharing playlists to NewPipe. I also moved the option up so enqueue is positioned right after the other player options.

~~The commit history of your branch is a little strange.~~

Details

grafik

~~I wanted to do a quick rebase but that's not possible without resolving a bunch of conflicts. Please cherry pick the two commits, fix the conflicts, undo the changes in libs.version.toml and force push. After that this is good to go.~~

TobiGr avatar Dec 14 '25 12:12 TobiGr

this simple change was ported back to dev (acaaec2cdef3d632ec579ffc365ad2d6eb760919, 5582eac1c45aa1ce0fc967ae1b437fee5b1beb42)

TobiGr avatar Dec 20 '25 20:12 TobiGr

Hello and thank you for the PR. I added a commit to check that there is a queue to which the user can enqueue items. I also made the enqueue option available when sharing playlists to NewPipe. I also moved the option up so enqueue is positioned right after the other player options.

~~The commit history of your branch is a little strange.~~

Details

grafik

~~I wanted to do a quick rebase but that's not possible without resolving a bunch of conflicts. Please cherry pick the two commits, fix the conflicts, undo the changes in libs.version.toml and force push. After that this is good to go.~~

Somehow I missed this comment. My bad.

Actually in my testing I have seen one bug. Start playing an item in the app -> click on external link, select enquque option in the menu -> open the app, very that external item is now added -> within the app long press on another item and try "enqueue" and "enqueue next" option. The "enque next" option did not add item to the list at all.

I see there have been a PR with "enqueue next" as well, so will test this workflow in 28.1 apk

Update: Tested on v28.1, not seeing the issue

HatakeKakashri avatar Dec 22 '25 03:12 HatakeKakashri