NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Refactor: Video detail fragment kotlin conversion

Open Profpatsch opened this issue 10 months ago • 2 comments

What is it?

  • [ ] Bugfix (user facing)
  • [ ] Feature (user facing)
  • [x] Codebase improvement (dev facing)
  • [ ] Meta improvement to the project (dev facing)

Description of the changes in your PR

This is a bunch of refactors that convert PlayerHolder and VideoDetailFragment to kotlin.

Please don’t review for “kotlin style”, there’s a lot more commits that are already done that do the fixup of the kotlin style.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Profpatsch avatar Jun 05 '25 12:06 Profpatsch

Please don’t review for “kotlin style”, there’s a lot more commits that are already done that do the fixup of the kotlin style.

Ooops I read this only now, I don't know why I did not notice before :worried:. I just pushed a commit to fix the kotlin style, feel free to revert it if you have already done it elsewhere.

Stypox avatar Jun 09 '25 13:06 Stypox

Conflicts fixed by looking at https://github.com/TeamNewPipe/NewPipe/compare/006b4c9ae17e063e0b105759c20c46a7e1f7710c...refactor, where 006b4c9ae17e063e0b105759c20c46a7e1f7710c is the commit this PR was based on. These are the differences in the three files with conflicts:

image image image

Stypox avatar Jul 16 '25 13:07 Stypox