NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

SearchFragment: show service name in search hint

Open Profpatsch opened this issue 6 months ago • 3 comments
trafficstars

What is it?

  • [ ] Bugfix (user facing)
  • [x] Feature (user facing)
  • [ ] Codebase improvement (dev facing)
  • [ ] Meta improvement to the project (dev facing)

Description of the changes in your PR

The only hint (haha) which service one is searching in is currently the color of the background. This is super confusing, yesterday a friend tried to search for a video on youtube and the app was set to Bandcamp, and they were super confused why nothing turned up.

So let’s put the name of the service in the hint!

The updateService() thing is a little confused, but I didn’t want to refactor to improve the logic. It’s not doing anything computationally intensive anyway.

For PeerTube, the sidebar calls it FramaTube but the service name is PeerTube, I’m not sure why that is the case. Looks like the string depends on the name of the instance? Hm, can be improved later I think.

Before/After Screenshots/Screen Record

after:

https://github.com/user-attachments/assets/4e88d826-feb2-4cd1-84e6-4dcf203cd38c

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Profpatsch avatar May 07 '25 08:05 Profpatsch