NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Fix gradle

Open TobiGr opened this issue 1 year ago • 2 comments

What is it?

  • [x] Bugfix (user facing)
  • [ ] Feature (user facing)
  • [ ] Codebase improvement (dev facing)
  • [ ] Meta improvement to the project (dev facing)

Description of the changes in your PR

Jitpack is somewhat buggy. See https://github.com/TeamNewPipe/NewPipeExtractor/issues/1066

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

TobiGr avatar Oct 10 '24 13:10 TobiGr

Mmmh, the build is still failing. We should switch away from Jitpack and use a local git build, as I did with Dicio (see here)

Stypox avatar Oct 12 '24 19:10 Stypox

I tried this PR and the build is still failing. Although, if I only change this line, then it builds successfully. This build issue seems to be only with NewPipeExtractor.

--- a/app/build.gradle
+++ b/app/build.gradle
@@ -198,7 +198,7 @@ dependencies {
     // name and the commit hash with the commit hash of the (pushed) commit you want to test
     // This works thanks to JitPack: https://jitpack.io/
     implementation 'com.github.TeamNewPipe:nanojson:1d9e1aea9049fc9f85e68b43ba39fe7be1c1f751'
-    implementation 'com.github.TeamNewPipe:NewPipeExtractor:v0.24.2'
+    implementation 'com.github.teamnewpipe:NewPipeExtractor:v0.24.2'
     implementation 'com.github.TeamNewPipe:NoNonsense-FilePicker:5.0.0'
 
 /** Checkstyle **/

syphyr avatar Oct 19 '24 20:10 syphyr

Superseded by #11636

Stypox avatar Oct 23 '24 20:10 Stypox