NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Migrate video description and about channel fragments to Jetpack Compose

Open Isira-Seneviratne opened this issue 1 year ago • 6 comments

What is it?

  • [x] Bugfix (user facing)
  • [x] Feature (user facing)
  • [x] Codebase improvement (dev facing)
  • [ ] Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Migrate the video description and about channel UIs to Jetpack Compose.
  • Fix a crash that occurs when minimizing the app while the about channel UI is open.

Before/After Screenshots/Screen Record

Before Before After After
Before Before After After

https://github.com/user-attachments/assets/16e235ec-cedd-42ee-94cc-1594f3823686

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Isira-Seneviratne avatar Aug 31 '24 10:08 Isira-Seneviratne

I suggest three things on this PR:

  • Reduce a little bit size of font
  • Use grey color like chip background
  • Add ability to scroll to the top just under the video (on little screen, like foldable phone, it's hard to scroll to the video description) -> maybe need to do in a separate PR?

Jean-BaptisteC avatar Nov 28 '24 10:11 Jean-BaptisteC

I got a weird behaviour while testing which results in the comments reloading:

  1. Open a (YouTube) video
  2. Comments tab is open and loaded by default
  3. Swipe twice to see related streams and the stream description
  4. Swipe back twice or tap on the comments button
  5. Comments reload

Further swiping and changing back to the comments tab cause further reloads of the tab. I am currently unable to capture a screenrecording. I'll try this later if you need it.

TobiGr avatar Mar 15 '25 12:03 TobiGr

@TobiGr yeah that's because comments are not cached anymore... This was a leftover from the comments PR. It's normal for Android tabs to get destroyed at a distance of 2 from the current position.

Stypox avatar Mar 15 '25 23:03 Stypox

Rewriting the video details fragment using Compose should fix it; alternatively, in the short term it could be migrated to using a view model that could be shared with the comment fragment.

Isira-Seneviratne avatar Mar 16 '25 10:03 Isira-Seneviratne