NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Replaced symlink (causing issues with windows) with the file the symlink was pointing to

Open Thompson3142 opened this issue 1 year ago • 1 comments

What is it?

  • [ ] Bugfix (user facing)
  • [ ] Feature (user facing)
  • [ ] Codebase improvement (dev facing)
  • [x] Meta improvement to the project (dev facing)

Description of the changes in your PR

When the git repo is cloned from a windows machine it does not (always) recognize symlinks. I simply copied the contents of the file the symlink was pointing to, into the file with the symlink.

Fixes the following issue(s)

https://github.com/TeamNewPipe/NewPipe/issues/1096

Due diligence

Thompson3142 avatar Aug 28 '24 22:08 Thompson3142

If this change should be documented in some way to avoid errors when editing only one of the two existing files let me now. (Also my first pull request so be gentle :) )

Thompson3142 avatar Aug 28 '24 22:08 Thompson3142

Realized i copied a different file than the one which was actually referenced by the symlink, sorry for the confusion.

Thompson3142 avatar Aug 29 '24 18:08 Thompson3142

Superseded by #11636

Stypox avatar Oct 23 '24 20:10 Stypox