Migrate empty_state_view xml/view to Jetpack Compose
What is it?
- [ ] Bugfix (user facing)
- [ ] Feature (user facing)
- [x] Codebase improvement (dev facing)
- [ ] Meta improvement to the project (dev facing)
Description of the changes in your PR
As part of the rewrite effort, this PR migrates the empty_state_view xml and view to Jetpack Compose. It contains the following
- introduce
EmptyStateComposableand specs used different fragments. - introduce
EmptyStateUtilto provide java -> kotlin interpolation methods. - use a simple
MutableState<EmptyStateSpec>to trigger recompositation upon ui state changes.
Before/After Screenshots/Screen Record
| feature | before | after |
|---|---|---|
| bookmark-light | ||
| bookmark-dark |
More screenshot is coming before PR commition.
Fixes the following issue(s)
- Fixes # https://github.com/TeamNewPipe/NewPipe/issues/11198
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence
- [x] I read the contribution guidelines.
cc @opusforlife2 PTAL. Let me know if other code reviewers should be in the review loop as well.
Quality Gate passed
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Gonna rebase this now that the other PR is merged
@toliuweijing you are not allowing maintainers to push to your PR branch, so I’ll open a new PR.
PR: https://github.com/TeamNewPipe/NewPipe/pull/11725