NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Migrate empty_state_view xml/view to Jetpack Compose

Open toliuweijing opened this issue 1 year ago • 2 comments

What is it?

  • [ ] Bugfix (user facing)
  • [ ] Feature (user facing)
  • [x] Codebase improvement (dev facing)
  • [ ] Meta improvement to the project (dev facing)

Description of the changes in your PR

As part of the rewrite effort, this PR migrates the empty_state_view xml and view to Jetpack Compose. It contains the following

  1. introduce EmptyStateComposable and specs used different fragments.
  2. introduce EmptyStateUtil to provide java -> kotlin interpolation methods.
  3. use a simple MutableState<EmptyStateSpec> to trigger recompositation upon ui state changes.

Before/After Screenshots/Screen Record

feature before after
bookmark-light s22 Screenshot_20240819_161005
bookmark-dark Screenshot_20240819_160210 Screenshot_20240819_160812

More screenshot is coming before PR commition.

Fixes the following issue(s)

  • Fixes # https://github.com/TeamNewPipe/NewPipe/issues/11198

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

toliuweijing avatar Aug 19 '24 07:08 toliuweijing

cc @opusforlife2 PTAL. Let me know if other code reviewers should be in the review loop as well.

toliuweijing avatar Aug 19 '24 07:08 toliuweijing

Gonna rebase this now that the other PR is merged

Profpatsch avatar Nov 20 '24 10:11 Profpatsch

@toliuweijing you are not allowing maintainers to push to your PR branch, so I’ll open a new PR.

Profpatsch avatar Nov 20 '24 13:11 Profpatsch

PR: https://github.com/TeamNewPipe/NewPipe/pull/11725

Profpatsch avatar Nov 20 '24 13:11 Profpatsch