TeamNewPipe
Tapping on timestamp causes popup player to start from beginning
Checklist
- [X] I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
- [X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
- [X] I have read the FAQ and my problem isn't listed.
- [X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
- [X] This issue contains only one bug.
- [X] I have read and understood the contribution guidelines.
Affected version
0.27.1
Steps to reproduce the bug
- Open a video
- Go to comments
- View replies of a comment
- Tap a timestamp in a reply
Expected behavior
The video starts in the popup player from that timestamp.
Actual behavior
The video starts in the popup player from the beginning.
Screenshots/Screen recordings
No response
Logs
No response
Affected Android/Custom ROM version
Android 13
Affected device model
moto g52
Additional information
No response
Does that also happen once you have started the video? I can only reproduce this if either:
- I have autoplay disabled and click on a timestamp before starting the video
- I have played the video - opened a timestamp - closed it without resuming the video - open a timestamp again (can be the same)
If that is the case i probably know the issue: The playQueue in Player is null if a timestamp "starts" the player since initPlayback was never called. If handleIntent is called on a "fresh" (initPlayback was never called) Player object it can't handle timestamps since in the big if (in line 393) the playQueue is needed to create a pop-up with timestamp.
Assuming my previously mentioned steps to reproduce are correct, i have now found the actual problem: https://github.com/TeamNewPipe/NewPipe/blob/64ad05d81399f48627224a09039feb77b730f6d4/app/src/main/java/org/schabi/newpipe/player/Player.java#L465
This line seems to reset the recoveryPosition to zero even though that should not be the case here. I am not sure what the intended purpose is so i am hesitant to just remove it and call it a day.
