NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

move seekbar above video title

Open GreenMystic opened this issue 1 year ago • 7 comments

Checklist

  • [X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • [X] I have read the FAQ and my problem isn't listed.
  • [X] I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • [X] I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • [X] This issue contains only one feature request.
  • [X] I have read and understood the contribution guidelines.

Feature description

hi dev please consider to move the seekbar to be above video title like YouTube 🙏

Why do you want this feature?

because current seekbar position is uncomfortable to use i have hard time to tap on seekbar so far -_-

Additional information

YouTube Seekbar preview is exactly placed between video title and video Screenshot_20240616-150403_1

Meanwhile not with newpipe seekbar is slightly inside video or media Screenshot_20240616-150256_1_1

thanks for reading and consideration dev 🙏

GreenMystic avatar Jun 16 '24 07:06 GreenMystic

@opusforlife2 Sorry to bother, since this is a feature request, I am wondering if we can work on this.

haoyeau avatar Oct 04 '24 04:10 haoyeau

Hey @HaoAnu! Thanks for showing an interest in contributing. Unfortunately, the app is undergoing a major refactor right now, and devs are discouraged from sending in feature PRs. You can still do so, but there's a very low probability of them being reviewed any time soon. If you're still okay with that, please go ahead!

opusforlife2 avatar Oct 07 '24 16:10 opusforlife2

@opusforlife2 Sorry to bother, since this is a feature request, I am wondering if we can work on this.

can you do that on fork turbular instead of official? since official doing refactor code

GreenMystic avatar Oct 08 '24 14:10 GreenMystic

Sorry, what's turbular?

haoyeau avatar Oct 08 '24 23:10 haoyeau

This https://github.com/polymorphicshade/Tubular

oddtoddy avatar Oct 09 '24 01:10 oddtoddy

This https://github.com/polymorphicshade/Tubular

yes bcs official might take a while to refactor the code 🙏😅

GreenMystic avatar Oct 09 '24 10:10 GreenMystic

Sorry, we can not keep on working on this issue based on the following reasons:

  1. To place the progress bar between the playback interface and the title, the progress bar needs to be placed in the upper layer component. This is quite a lot change to make due to current PlayerUI design. Also considering this bar is also reused in landscape mode, it will add more changes to adapt orientation change.
  2. There is a side panel on this screen which will intercept the scroll on the left side. This will interrupt the seek function at the beginning, which I believe is not expected.
  3. There is a preview of seek on the top of current seekbar. If we move the bar below the playback interface, it is too far between them, which I think is also not expected.

Because of these reasons, I do not think this feature is feasible on current code design.

haoyeau avatar Oct 15 '24 09:10 haoyeau