NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Fix RSS button visibility

Open snaik20 opened this issue 9 months ago • 1 comments

What is it?

  • [x] Bugfix (user facing)

Description of the changes in your PR

  • The onPrepareMenu callback is invoked after setting the visibility of the menu items.
  • Due to this, the menu item resets to it's default visibility.
  • Now updating the menu item within the callback.
  • Also migrated to the MenuHost framework to reduce dependency on deprecated APIs.

Before/After Screenshots/Screen Record

Fixes the following issue(s)

  • Fixes #11059

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

snaik20 avatar May 12 '24 21:05 snaik20

Use 'fixes' or 'closes' keyword so that solved issues are closed automatically.

opusforlife2 avatar Jun 25 '24 01:06 opusforlife2