NewPipe
NewPipe copied to clipboard
Fix RSS button visibility
What is it?
- [x] Bugfix (user facing)
Description of the changes in your PR
- The
onPrepareMenu
callback is invoked after setting the visibility of the menu items. - Due to this, the menu item resets to it's default visibility.
- Now updating the menu item within the callback.
- Also migrated to the
MenuHost
framework to reduce dependency on deprecated APIs.
Before/After Screenshots/Screen Record
Fixes the following issue(s)
- Fixes #11059
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence
- [x] I read the contribution guidelines.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Use 'fixes' or 'closes' keyword so that solved issues are closed automatically.