NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Make prev/next headset buttons configurable

Open dvalter opened this issue 1 year ago • 3 comments

Also changes behavior of A13+ player notification buttons.

and improves

What is it?

  • [ ] Bugfix (user facing)
  • [x] Feature (user facing)
  • [ ] Codebase improvement (dev facing)
  • [ ] Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Adds setting for prev/next track headset actions. Fixes #7880
  • Also applies the same actions to Android 13+ player notification fixed buttons. Fixes regression in #10712 fix of #9764

Before/After Screenshots/Screen Record

  • Before: 1
  • After: 2 3

Fixes the following issue(s)

  • Fixes #7880

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

dvalter avatar May 06 '24 21:05 dvalter

The only drawback is that it's seemingly impossible to change the appearance of the notification buttons on A13 without making all actions custom like in #10580.

However in that case headset functionality can be restored via an overridden MediaButtonEventHandler

dvalter avatar May 06 '24 22:05 dvalter

Looks like the tests has failed for some unrelated reasons. One due to some access issues and the other in the test that should not be affected by my changes.

dvalter avatar May 10 '24 20:05 dvalter