NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Adjust the playlist bookmark item layout for RTL languages

Open AbdeltwabMF opened this issue 1 year ago • 5 comments

What is it?

  • [X] Bugfix (user facing)
  • [ ] Feature (user facing)
  • [ ] Codebase improvement (dev facing)
  • [ ] Meta improvement to the project (dev facing)

Description of the changes in your PR

The playlists' bookmark items do not align correctly and have a layout overlap issue when the channel name is in a right-to-left (RTL) language, such as Arabic. Therefore, this change focuses on adding a right boundary to the uploader element, similar to the playlist title, to resolve this issue.

Also, make small adjustments to some items to align them with the uploader element. Screenshot 2024-05-01 021233

Before/After Screenshots/Screen Record

  • Before: Screenshot_20240501_020609_NewPipe

  • After: Screenshot_20240501_014114

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

AbdeltwabMF avatar Apr 30 '24 23:04 AbdeltwabMF

@TobiGr, for some reason, Android Studio cannot symbolically link this file during the local build https://github.com/TeamNewPipe/NewPipe/blob/879d7a24f05ab06510be249f2f3b5109f7c89dcc/app/src/main/res/layout-land/list_stream_card_item.xml#L1 However, it magically works when I try to copy the content it points to. I'm unsure why it works here with this symlink and doesn't work on my local build!

AbdeltwabMF avatar May 03 '24 22:05 AbdeltwabMF

Are you using Windows?

TobiGr avatar May 08 '24 12:05 TobiGr

Are you using Windows?

Yes. Windows 11 Pro 23H2

AbdeltwabMF avatar May 09 '24 16:05 AbdeltwabMF

@snaik20, thank you. I am glad to contribute.

Regarding the adjustment to the height, I scaled down the ImageView to match the width of the title and uploader text, as illustrated in the screenshots below, hence the "51dp".

As you suggested, instead of directly setting the static height, I used the layout_alignTop and layout_alignBottom constraints.

Before

image

After

image

After last fix (using layout_alignTop/Bottom)

image

AbdeltwabMF avatar May 18 '24 13:05 AbdeltwabMF

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 18 '24 14:05 sonarqubecloud[bot]