NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Settings redesign debug page

Open snaik20 opened this issue 11 months ago • 13 comments

What is it?

  • [ ] Bugfix (user facing)
  • [x] Feature (user facing)
  • [ ] Codebase improvement (dev facing)
  • [ ] Meta improvement to the project (dev facing)

Description of the changes in your PR

Initial Work for Settings Page with Jetpack Compose

  • Implemented a new settings page using Jetpack Compose.
  • Added a new settings option to enable the redesigned settings page.
  • This option allows for gradual integration and testing of the new settings page, minimizing disruptions to current functionality.

Plan for Settings Items:

  • Jetpack Compose does not have a direct equivalent to the Preference/settings library.
  • We could consider using third-party libraries that offer preference items as composables.
  • However, these libraries may be incomplete or lack active development.
  • Given our specific needs for only a subset of preference types, creating custom composables would be beneficial.
  • This approach allows for fine-tuning the components to our specific use case.

Next Steps:

  • Continue development by adding more composables for settings functionalities and screens.

Fixes the following issue(s)

  • Fixes #9587

Screenshots/Videos

NewPipe_SwitchPreference_ON NewPipe_SwitchPreference_OFF

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

snaik20 avatar Mar 09 '24 22:03 snaik20

After enabling the toggle and restarting the app, all I'm getting is a text at the top right saying "Settings", and now I can't go back to the original layout. Is that the intended current PR state or a bug somewhere?

Never mind. That's what #10849 is for.

opusforlife2 avatar Mar 26 '24 15:03 opusforlife2

~After enabling the toggle and restarting the app, all I'm getting is a text at the top right saying "Settings", and now I can't go back to the original layout. Is that the intended current PR state or a bug somewhere?~

Never mind. That's what #10849 is for.

Thanks for checking out the work. You're absolutely correct. This PR focuses on laying the groundwork for Jetpack Compose in the settings page.

We're currently waiting for feedback on theme and color design choices. This feedback might influence the overall implementation details. Once the design aspects are reviewed and approved, we'll proceed with building the rest of the settings page functionality.

Regarding PR #10849, that branch holds the previous implementation without Jetpack Compose. We've kept it open temporarily for reference until this PR with the Compose approach receives some reviews. After we have a clearer direction, we'll close PR #10849.

snaik20 avatar Mar 26 '24 16:03 snaik20

We're currently waiting for feedback on theme and color design choices.

Where is this taking place?

opusforlife2 avatar Mar 26 '24 17:03 opusforlife2

We're currently waiting for feedback on theme and color design choices.

Where is this taking place?

I had only pinged in the Matrix room.

snaik20 avatar Mar 26 '24 17:03 snaik20

@snaik20 if you want, you can start to develop the Jetpack Compose components for settings screen. This will be our first step toward rewriting :-D

Stypox avatar Mar 28 '24 21:03 Stypox

@snaik20 if you want, you can start to develop the Jetpack Compose components for settings screen. This will be our first step toward rewriting :-D

Updated the PR to add a working SwitchPreference. The plan ahead is to add other components similarly in followup PRs and integrate the Settings page altogether.

snaik20 avatar Apr 24 '24 23:04 snaik20