NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Manually press play button

Open suudzi opened this issue 1 year ago • 10 comments

Checklist

  • [X] I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • [X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • [X] I have read the FAQ and my problem isn't listed.
  • [X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • [X] This issue contains only one bug.
  • [X] I have read and understood the contribution guidelines.

Affected version

0.26.0

Steps to reproduce the bug

Firts video play automatically but when i click on another video i must click on play. It repeating: first video play, second not, third play, fourth not.. This started about ~2 months later. Waited for new version but that bug is still there

Its better to see an attached video

Expected behavior

Play automatically every video if i have that ticked in setting.

Actual behavior

No response

Screenshots/Screen recordings

https://github.com/TeamNewPipe/NewPipe/assets/154591093/3a11787f-0ea9-4d5c-abf3-a56d4bab48be

Logs

No crash log

Affected Android/Custom ROM version

Original samsung one ui 6.0 - android 14

Affected device model

Samsung S22 Ultra

Additional information

No response

suudzi avatar Dec 23 '23 22:12 suudzi

Even in your new version that still happens 😭 0.26.1

suudzi avatar Dec 29 '23 09:12 suudzi

Seems like the autoplay only triggered if the player is closed (at 0:4 click × button), then it should work properly, maybe the autoplay trigger code should be moved, so that it will trigger when any videos clicked

ABJ4403 avatar Jan 16 '24 02:01 ABJ4403

Having the same exact issue here, but only started a few days ago. Autoplay was working fine before that.

Using current version (tried both fdroid and website download)

Same issue as OP described above, 1st/3rd/5th/7th etc video will autoplay, and the 2nd/4th/6th/8th etc videos won't auto start

Anyone else having this issue?

I'm not sure why I've only just started having this issue, months after OP @suudzi has posted. Was there a recent update?

doogle11 avatar Mar 17 '24 21:03 doogle11

No recent update. And all videos work fine for me. You guys may have something else in common, like OS or devices.

opusforlife2 avatar Mar 26 '24 16:03 opusforlife2

This started happening for me recently too, but only sometimes. NewPipe v0.26.1, Nokia 6.1, LineageOS 10

As ABJ4403 mentioned, auto-play works every time if the player is closed first.

@opusforlife2 do you have any suggestions on how this might be caused in the code? Is there a reason that auto-play would not trigger in every case?

emjas92 avatar Mar 26 '24 20:03 emjas92

I'm not a dev, so no idea. But multiple devices and OSs does point to a Newpipe bug, instead of elsewhere.

opusforlife2 avatar Mar 26 '24 20:03 opusforlife2

@opusforlife2 All good. Sorry for my assumption. You're very active here so thought you may have had more insight than me.

emjas92 avatar Mar 26 '24 20:03 emjas92

The problem persists on version 0.27 as well. I have a theory about this issue. It may be having something to do with the new Media controller on Android 12+. If you look at the notifications immediately before a video loads, NewPipe tries to create its own media player notification, and then it gets overwritten by the Android's. When trying to load another video, NewPipe tires to do that again, and it fails.

Another thing to note is that if you try and play the interrupted video, it may keep on being stopped, and checking in the notifications. The Andoird's media controller isn't present, but NewPipe's. It can also be dismissed, which also leads to the video being stopped, and needs to be played again.

Again, it's just my theory. This problem doesn't seem to affect older Android versions.

GotRobbd avatar Jun 27 '24 13:06 GotRobbd

Problem is still ongoing on v0.27.1. I just encountered this exact issue when switching phones. I have 3 devices to use as a reference for this.

Old main phone: Oneplus 7 Pro (OxygenOS 12.1, Android 12) New main phone: Samsung Galaxy S22 Plus (One UI v6.1, Android 14) Backup phone: Samsung Galaxy A50 (One UI v3.1, Android 11)

All 3 devices have the exact same settings as far as I'm aware. The S22+ encountered this issue immediately and try as I might, the issue will not go away no matter what I try and change. The A50 didn't have this issue nor did the OP7, even though it's running a version of Android 12 with the new media player. I do not know how much OnePlus changed their OS during the transition to Android 12, but historically they've been quite clean Android versions.

The recent hypothesis about this being rooted in the new media player still does seem the most plausible to me. With spamming suggested videos I was able to get the "second video" to play for a few seconds as I have set it to do, but after those couple of seconds, it reverts to the thumbnail as it did in the original example video. This to me suggests that the software settings on the side of NewPipe are working as they are intended, but they are overridden by the device once it catches up, thus resulting in the conflict and the video not playing. Background play for singular videos is also affected, but playlists and auto-enqueue next stream work normally automatically starting the playback of the next video.

Avinium avatar Jul 19 '24 14:07 Avinium

I wrote here a few months ago when first encountering this issue

recently I gave Pipepipe a try, it doesn’t reproduce this issue. How closely related is it are they in their code? I was under the impression that it’s built off of Newpipe?

doogle11 avatar Jul 28 '24 10:07 doogle11