Square screens: do NOT rotate to fullscreen

[allanlaal]

Checklist

• [X] I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
• [X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
• [X] I have read the FAQ and my problem isn't listed.
• [X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• [X] This issue contains only one bug.
• [X] I have read and understood the contribution guidelines.

Affected version

0.25.2

Steps to reproduce the bug

1. buy a Unihertz Titan qwerty keyboard phone :D OR set emulator screen resolution to 1432 × 1436 pixels
2. open NewPipe
3. open random video
4. tap Fullscreen

Expected behavior

video goes fullscreen without rotating, since the screen is square and its a portrait-mode-only phone

Actual behavior

video rotates 90°

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 10

Affected device model

Unihertz Titan

Additional information

this prolly affects other square-ish phones aswell (like the foldables)

[SameenAhnaf]

This is a feature request as existing code works as expected. Avoiding device/software specific label as all square videos should be played on portrait player.

[allanlaal]

@SameenAhnaf its not about square videos, its all videos on square screens

[opusforlife2]

There are hardly any such devices, so this label should apply. The point here is that rotating to landscape doesn't fulfill the purpose of 'going fullscreen' at all. The video dimensions will hardly change.

Maybe this simply involves checking a threshold for the aspect ratio, and if the device is below that, going full screen will leave off rotating as part of the process.

[SameenAhnaf]

@allanlaal I got your point. But what I meant is that square videos should be played on portrait player for ALL devices, not just square devices. Holding tall phones on portrait mode is more comfortable. So, that's how square videos should be handled.

[allanlaal]

Next level would be to autocrop black bars for square videos edited into portrait mode

[lis6502]

Another Unihertz Titan Pocket user here. As for me i don't expect any automagic detection if NewPipe is running on squar-ish aspect ratio. Single checkbock "force landscape mode on fullscreen" would do the trick because there are some beasts recording videos in portrait so i guess everyone would take benefit of such checkbox.

[allanlaal]

@lis6502 isn't it great when theres a square video turned into portrait with black bars, so you can watch a tiny square in the center of our phones square screen :D :D

that reminds me: https://github.com/TeamNewPipe/NewPipe/issues/10775