NewPipe-legacy icon indicating copy to clipboard operation
NewPipe-legacy copied to clipboard

[Feature request] Support for Android 4.0.4

Open tbjorheim opened this issue 5 years ago • 48 comments

Hi. As far as I can understand, the NewPipe-legacy requires Android 4.1. Is it possible to make it work on Android 4.0.4 as well?

tbjorheim avatar Feb 23 '19 09:02 tbjorheim

Since my own phone has JellyBean, I didn't want to go that low on the version list, because it's hard to guarantee the usability that way.
It's entirely possible to go that low for now, since there were not substantial changes made to the application yet.
Additionally, the "old player" was entirely pruned from the application in https://github.com/TeamNewPipe/NewPipe/pull/2129 and I am not quite sure of the consequences yet, since NewPipe has been working fine on my 4.3 device, it might have had relevance for OS versions older than JellyBean, but since I can't test that on a physical device, I would prefer to refrain from supporting that.

I'm also just familiarizing myself with the codebase and Android development in general, but I'll do my best to do the appropriate research on the topic of this "old payer" and when deemed irrelevant, I will definitely start supporting IceCreamSandwich.

friendlyanon avatar Feb 23 '19 18:02 friendlyanon

I have used NewPipe on my Samsung Galaxy Tab 8.9 with Android 4.0.4 until version 15 of NewPipe, when support for 4.0.3 - 4.3 was dropped. And it has worked very well, but since Youtube changed something, the old 14.2 version is not working anymore.

I'm not a coder myself, but will gladly help with testing new versions on my tablet with Android 4.0.4.

Youtube/Google has also recently blocked the stock Youtube app on 4.0.4 and it now only shows a message that you have to upgrade. But that's not possible on Android 4.0.4. And I have read on many forums about people that are very unhappy about this. Many still have phones and tablets which still works very well, and I think it's bad that they need to be trashed just because Youtube/Google decide they are to old.

tbjorheim avatar Feb 23 '19 21:02 tbjorheim

Would be great to have support for devices with android 4.0.4, please don't drop them.

vad1m avatar Mar 11 '19 11:03 vad1m

Hi. Any news on support for 4.0.4?

I compile my own version for now using Android Studio and follow the instructions from johnb-xp in this post https://github.com/TeamNewPipe/NewPipe/issues/2033 but selecting minAPI 15 which is for Android 4.0.4.

It works great except the internal videoplayer doesn't work. But have selected external player and open in either VLC, X-plore file manager video player or Dolphin web browser video player. The last two works best.

But I'm only able to get the debug version to work. I'm not familiar at all with developing Android apps, but manage to do just this to make NewPipe work on my tablet. :)

If anyone else still need a version for 4.0.4, please let me know, and I can put the debug version I compile up for download somewhere.

tbjorheim avatar Jun 14 '19 15:06 tbjorheim

@friendlyanon: I also would like to have this support and going even lower if possible. I can't test it right now but I will be able to do it in the future.

ale5000-git avatar Jul 08 '19 11:07 ale5000-git

The Minimun API level is 16 (Android 4.1) ??

I am using Cyanogenmod Optimus Nexus Me

$ adb shell getprop ro.build.version.release

4.4

but :

$ adb shell getprop ro.build.version.sdk

10

can the legacy version be more legacy until API level 10 ?

timoteo7 avatar Jul 21 '19 17:07 timoteo7

Hi again. Has anyone be able to compile v0.18.2 for Android 4.0.4 (API 15)?

I tried, but it seems like exoPlayer need API 16. Is it possible to compile without the player, to use an external player instead?

tbjorheim avatar Jan 29 '20 22:01 tbjorheim

I'm not sure if I should open a new issue, but I'd also like to have this on my old Motorola Xoom, which only has 4.0.3.

Kovaelin avatar Feb 21 '20 21:02 Kovaelin

@Kovaelin I would like that version as well ...

malekairmaroc7 avatar Apr 08 '20 11:04 malekairmaroc7

Is there a working version for Android 4.0.3?

malekairmaroc7 avatar Apr 08 '20 12:04 malekairmaroc7

Here is the working version for Android 4.0.3 based on 0.19.2 source. Change log:

  1. Disable Resolution spinner (only API 15)
  2. Disable popup video
  3. Add old player again to support very old device like my KFHD 7 Tate
  4. Disable markdown

I currently use external VLC for background playback.

Of course, no malicious code anymore

[friendlyanon: Edited out link to binary blob]

sh000gun avatar Apr 19 '20 08:04 sh000gun

@sh000gun I appreciate your enthusiasm for something I myself don't really have time for due to uni, but please avoid distributing binary blobs like this.
I'm also pretty sure binary distribution without source code provided is in violation of the GNU General Public License.
I'd be more than happy to accept a Pull Request if you can make one however.

friendlyanon avatar Apr 19 '20 11:04 friendlyanon

@sh000gun Thank you much for the effort you've done! I installed the app on 4.0.3 and it works except the video player. There is just a black screen. Any Idea why?

malekairmaroc7 avatar Apr 19 '20 17:04 malekairmaroc7

@malekairmaroc7 maybe the video player can't play the specific video resolution. I set default resolution 360p in the Setting-->Video & audio and mostly it work all the time

sh000gun avatar Apr 20 '20 02:04 sh000gun

Well, seems a video player issue then. I even can't play live stream in 360p

malekairmaroc7 avatar Apr 20 '20 11:04 malekairmaroc7

@malekairmaroc7 Here is my latest version that fix Resolution Spinner so you can choose it to play

You can download at: https://drive.google.com/open?id=1_9roWosYM_sf-idB8wJ3ELUJjW-Px2WO

sh000gun avatar Apr 20 '20 12:04 sh000gun

Thank you for the effort! It still doesn't work either. Now, I don't know where the problem is. The Android TV Box supports up to 1080p. When I choose something higher than 360p it says "Video couldn't load" or just a black screen... Happens on live streams and videos

malekairmaroc7 avatar Apr 20 '20 12:04 malekairmaroc7

The problems is Newpipe old player limitation. I think it only plays 720p and 1080, live stream is another topic like this discussion https://github.com/TeamNewPipe/NewPipe/issues/517.

You can play 1080p with external player option turn on (with VLC) and of course it will not have audio by current Newpipe implementation. Another stupid workaround is using 2 external players parallel: one running audio stream by clicking background and other one for video playback the same time :)

sh000gun avatar Apr 20 '20 14:04 sh000gun

I see. I tried using MX Player (VLC doesn't run well), but still same issue here. Thank you for replying!

malekairmaroc7 avatar Apr 20 '20 14:04 malekairmaroc7

Thank you very much for your hard work. Can you release 0.19.03 with youtube music suppor and minimal API 17 (Android 4.2.2) Thank you

DavidAntonin avatar May 14 '20 17:05 DavidAntonin

@sh000gun Thank you!!

Unfortunately I run into a guru meditation error when starting a video

malekairmaroc7 avatar May 15 '20 12:05 malekairmaroc7

@sh000gun Thank you for working on the legacy version. If you want, I can add you as collaborator to this repository, so we can ship your changes to everyone using F-Droid. But please do not upload binaries to google drive (or somewhere else) without sharing its source, too.

TobiGr avatar May 15 '20 13:05 TobiGr

@sh000gun Thanks for all the work on the legacy version!

Even though there are methods for old devices to run custom ROMs that are more up to date, it's very nice to have support for previous official Android versions that were tablet-centric, and not just scaled up phone versions.

Kovaelin avatar May 15 '20 16:05 Kovaelin

NewpipeLegacy for 4.0.3 up with libvlc

https://github.com/sh000gun/NewPipe-legacy/releases

sh000gun avatar Jun 22 '20 06:06 sh000gun

@sh000gun Thanks a lot for making a fork working on Android 4.0.x

Works great on my Android 4.0.4 tablet (API 15). The only issue I have noticed so far is that there is some lag when starting a video using the build in video player. The sound starts first, and after a few seconds the picture/video is shown. Same happens if I skip to another place in the video. Maybe the VLC player is a bit to demanding for my tablet, Samsung Galaxy P7320 (same as P7300 but with LTE/4G).

In fact, the same happens if I use VLC as external player. (Version 3.0.13 which is the latest available for Android 4.0.4)

But I been using external player with the video player from the X-plore file manager, and that has been working very well. It starts fast, and no lag.

So thanks again @sh000gun and hope you will keep your fork up to date when newer Newpipe version is released. At least when there is issues due to Youtube changes makes video unable to play. I'm not very interested in a lot of new fancy features, I just want to be able to watch Youtube on my tablet. :) And since the official Youtube app is no longer avaiable, Newpipe is the best option.

tbjorheim avatar Jun 28 '20 15:06 tbjorheim

@sh000gun Thanks a lot for making a fork working on Android 4.0.x

Works great on my Android 4.0.4 tablet (API 15). The only issue I have noticed so far is that there is some lag when starting a video using the build in video player. The sound starts first, and after a few seconds the picture/video is shown. Same happens if I skip to another place in the video. Maybe the VLC player is a bit to demanding for my tablet, Samsung Galaxy P7320 (same as P7300 but with LTE/4G).

That's my issue as well. VLC is too heavy for my device. MX Player works good on it. @sh000gun Can you update it to MX Player in any way? The HD Streams load at least but I only hear the sound. The picture doesn't react and is lagging :/ . Thank you for the effort so far!!

malekairmaroc7 avatar Jul 21 '20 14:07 malekairmaroc7

@sh000gun Thanks a lot for making a fork working on Android 4.0.x Works great on my Android 4.0.4 tablet (API 15). The only issue I have noticed so far is that there is some lag when starting a video using the build in video player. The sound starts first, and after a few seconds the picture/video is shown. Same happens if I skip to another place in the video. Maybe the VLC player is a bit to demanding for my tablet, Samsung Galaxy P7320 (same as P7300 but with LTE/4G).

That's my issue as well. VLC is too heavy for my device. MX Player works good on it. @sh000gun Can you update it to MX Player in any way? The HD Streams load at least but I only hear the sound. The picture doesn't react and is lagging :/ . Thank you for the effort so far!!

To be clear, I use libvlc library to integrate into Newpipe. MX Player is closed source so I cannot do anything

sh000gun avatar Jul 23 '20 01:07 sh000gun

Oh I see. Damn thats too bad. Thought MX Player is open source.

malekairmaroc7 avatar Jul 23 '20 13:07 malekairmaroc7

@sh000gun Your fork has stopped working due to recently Youtube changes. Can you please sync it with the latest changes to make it up to date with version 19.8? Thanks.

tbjorheim avatar Aug 02 '20 11:08 tbjorheim

Good to see there's still work being done for 4.0.X. Thanks.

I don't know what's going on, but even on non-legacy, there are some times when the app just won't load and then it'll just work again later.

Kovaelin avatar Aug 04 '20 20:08 Kovaelin