MidnightControls icon indicating copy to clipboard operation
MidnightControls copied to clipboard

Fix Network Protocol Error when joining server on NeoForge

Open Hedwig7s opened this issue 8 months ago • 1 comments

Adds a check to make sure the payload channel actually exists and switched to the correct NeoForge API. Fixes #326

Notes: sendPayloadC2S was updated, but I'm unsure of sendPacketC2S's functionality, although it seems to go unused anyway The client side handling of ControlsModePayload is loaded within CommonEvents and uses a class using client only APIs, making the packet unusable and logging an error on the server and fixing it is outside my knowledge (trust me, I tried). This is not an issue on fabric due to the fact that the client handling is registered seperately, and I'm unsure if this is possible on neoforge This issue is likely not exclusive to this branch, it's likely present in all the architectury branches

Will mark draft for now given the server error (non-fatal but could spam logs)

Hedwig7s avatar Apr 30 '25 17:04 Hedwig7s

Thanks a bunch! I'm not as familiar with NeoForge yet, but I think I can manage to fix the error you mentioned.

Motschen avatar May 03 '25 18:05 Motschen