journeymap icon indicating copy to clipboard operation
journeymap copied to clipboard

[1.19.2] Fabric - Oh the Biomes you Go flowers rendered as black dots

Open DracoExE opened this issue 2 years ago • 4 comments

JourneyMap Version: 1.19.1-5.9.0beta2-fabric

Fabric Loader Version: 0.14.9-1.19.2

Fabric API Version: 0.60.0-1.19.2

Describe the problem in repeatable steps:

  1. Create a new world using the Oh the Biomes you'll Go
  2. Search the Amaranth fields region
  3. Activate the render plants option in JourneyMap
  4. Check plants rendered in minimap and large map

Relevant errors from .minecraft/journeymap/journeymap.log:

No relevant errors from the log

Other details that might help

Modded tree leaves and blocks render with the current colors correctly.

Here're some images of the issue. As you can see, the flowers from the mod are varied and they have lots of colors, but they're all rendered as black dots, while vanilla plants are rendered correctly.

2022-08-26_16 35 20

2022-08-26_16 33 45

No idea if this happens with plants from other mods, might be interesting to check that too

DracoExE avatar Aug 26 '22 20:08 DracoExE

I will need to add an exception to not render these flowers on the map.

mysticdrew avatar Aug 26 '22 20:08 mysticdrew

you may be able to fix it by disabling the plant option in the cartography settings.

mysticdrew avatar Aug 26 '22 21:08 mysticdrew

you may be able to fix it by disabling the plant option in the cartography settings.

Disabling the option removes all the black dots, yes, but it also removes vanilla flowers dots in the map (which are colored correctly in the map)

I tried disabling and enabling the option again in the cartography settings, but it keeps rendering the modded flowers as black dots and vanilla flowers correctly after toggling the option.

Some other testing I just did:

  • Looks like all flowers from the ByG mod causes this issue, but other plant-like blocks from the mod such as beach grass, cattail sprouts and prairie grass have their dots colors rendered correctly.
  • I also tested the rainbow flower from the Blockus mod and the void lily from the Bosses of Mass Destruction mod, and they are rendered as a black dots too, so it seems it's a more general bug related to any modded flower rather than just the ones from the ByG mod

hope this information helps!

DracoExE avatar Aug 26 '22 21:08 DracoExE

It's not a bug, it's how the mods color the flowers. I need to handle them a special way.

The colors are derived from the texture color, but those flowers all have the same texture.

mysticdrew avatar Aug 27 '22 00:08 mysticdrew

Fixed for next release. 1.19.3 and 1.18.2 versions for both forge and fabric. This fix should resolve blocks for other mods too. I will close this ticket when release is published

mysticdrew avatar Dec 07 '22 21:12 mysticdrew

This issue is resolved and in beta for for 1.18.2 and 1.19.3 for both fabric and forge. Download here: https://www.curseforge.com/minecraft/mc-mods/journeymap/files https://modrinth.com/mod/journeymap/versions

mysticdrew avatar Dec 08 '22 15:12 mysticdrew