sklearn-crfsuite icon indicating copy to clipboard operation
sklearn-crfsuite copied to clipboard

Published 20 hours ago • verified publisher icon TeamHG-Memex

Fix flat_classification_report.

Open chriswales95 opened this issue 4 years ago • 9 comments

  • Change positional argument to keyword argument in flat_classification_report.

chriswales95 avatar Oct 27 '21 17:10 chriswales95

This is good, thank you for doing it. I hope it gets merged.

mdcclv avatar Nov 18 '21 20:11 mdcclv

Thanks!

glorytheksy avatar Mar 04 '22 02:03 glorytheksy

Is it possible to merge this PR and release a new version? @kmike ?

costika1234 avatar May 09 '22 22:05 costika1234

Is it possible to merge this PR and release a new version? @kmike ?

Apparently it's not @costika1234, unfortunately I've lost commit access to this repo :( I still have pypi access though. It's a matter of putting some work to copy the repo somewhere.

kmike avatar May 11 '22 07:05 kmike

I see, @kmike. Do you happen to know the people who have access to this repo? If not, then I would advise moving this repo somewhere else so that you can deploy a new version containing this fix (and subsequent ones, too).

costika1234 avatar May 11 '22 22:05 costika1234

I needed this change and the change from #69 for my code to work, so, seeing that the package is not updated anymore, I created a new fork with your fix and the fix from #69.

If anyone needs both, you can start using an updated version of this package by running this: pip install git+https://github.com/MeMartijn/updated-sklearn-crfsuite.git#egg=sklearn_crfsuite. Any updates are welcome, I'll accept all pull requests for bug fixes.

MeMartijn avatar Jun 27 '22 15:06 MeMartijn

@MeMartijn Thanks for addressing this. However, I'm still getting the same error AttributeError: 'CRF' object has no attribute 'keep_tempfiles' after installing the updated version. Can I provide anything to try and tackle what the problem may be? Forgive me for being a little green!

patrickquick avatar Jul 09 '23 17:07 patrickquick

@patrickquick I'm sorry to hear it doesn't work for you still! I needed this package for a single project and never touched it again, but you can still contribute to my fork that had the initial fix. That way, you would help people that run into your issue too. Here's a link: https://github.com/MeMartijn/updated-sklearn-crfsuite

MeMartijn avatar Jul 25 '23 09:07 MeMartijn

@MeMartijn Thanks for addressing this. However, I'm still getting the same error AttributeError: 'CRF' object has no attribute 'keep_tempfiles' after installing the updated version. Can I provide anything to try and tackle what the problem may be? Forgive me for being a little green!

If you're running it in a Jupyter notebook you may need to restart not only the kernel but the whole notebook server.

dhdaines avatar Aug 29 '23 17:08 dhdaines