eli5 icon indicating copy to clipboard operation
eli5 copied to clipboard

add lightgbm.booster support

Open qh582 opened this issue 7 years ago • 11 comments

mainly followed the logic of xgboost.booster support

qh582 avatar May 29 '18 03:05 qh582

Codecov Report

Merging #270 into master will decrease coverage by <.01%. The diff coverage is 97.91%.

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   97.22%   97.22%   -0.01%     
==========================================
  Files          44       44              
  Lines        2815     2845      +30     
  Branches      536      545       +9     
==========================================
+ Hits         2737     2766      +29     
  Misses         41       41              
- Partials       37       38       +1
Impacted Files Coverage Δ
eli5/lightgbm.py 95.23% <97.91%> (+0.36%) :arrow_up:

codecov-io avatar May 29 '18 04:05 codecov-io

Thanks for the PR @qh582 , at first sight it looks good 👍 I left a comment on how to fix the build. It would be also great if you could add tests for lightgbm.booster support, so that we don't break it in the future.

lopuhin avatar May 29 '18 07:05 lopuhin

@lopuhin Thanks for review and suggestion.

solved it.


I am doing the explain_prediction for regression part test, and I got 'y=y' in stead of 'y' as shown in the screenshot: image This seems ok for me, but I found eli5 using assert '<b>y</b>' in strip_blanks(expl_html) in tests.test_sklearn_explain_prediction.assert_trained_linear_regression_explained which point that it shoud be 'y' in my case. I am wondering if I missed the point here.

qh582 avatar May 30 '18 03:05 qh582

@lopuhin could you please check it?

qh582 avatar May 31 '18 05:05 qh582

@qh582 looks good! Would you mind updating a few notes in docs, mentioning this new feature?

  • https://github.com/TeamHG-Memex/eli5/blob/master/README.rst
  • https://github.com/TeamHG-Memex/eli5/blob/master/docs/source/libraries/lightgbm.rst
  • https://github.com/TeamHG-Memex/eli5/blob/master/docs/source/overview.rst

kmike avatar May 31 '18 11:05 kmike

@kmike I think this is ready, please check :)

qh582 avatar May 31 '18 12:05 qh582

@kmike Hope the new commit help. My previous piece of code is not strict enough.

qh582 avatar May 31 '18 15:05 qh582

It's been two month, could someone tell me why this merge hasn't been closed already? I really need this.

WestXu avatar Aug 08 '18 06:08 WestXu

I think PR is in great shape and we just need to check it again and merge it, hope to find time for it soonish, sorry for delay.

lopuhin avatar Nov 14 '18 17:11 lopuhin

Any plans about merging it, @lopuhin?

Dronablo avatar Apr 11 '20 19:04 Dronablo

Thanks you! This were merged in eli5-org/eli5#7 and released to PyPI with v0.11

lopuhin avatar Feb 10 '21 07:02 lopuhin