eli5
eli5 copied to clipboard
add lightgbm.booster support
mainly followed the logic of xgboost.booster support
Codecov Report
Merging #270 into master will decrease coverage by
<.01%. The diff coverage is97.91%.
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
- Coverage 97.22% 97.22% -0.01%
==========================================
Files 44 44
Lines 2815 2845 +30
Branches 536 545 +9
==========================================
+ Hits 2737 2766 +29
Misses 41 41
- Partials 37 38 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| eli5/lightgbm.py | 95.23% <97.91%> (+0.36%) |
:arrow_up: |
Thanks for the PR @qh582 , at first sight it looks good 👍 I left a comment on how to fix the build. It would be also great if you could add tests for lightgbm.booster support, so that we don't break it in the future.
@lopuhin Thanks for review and suggestion.
solved it.
I am doing the explain_prediction for regression part test, and I got 'y=y' in stead of 'y' as shown in the screenshot:
This seems ok for me, but I found eli5 using assert '<b>y</b>' in strip_blanks(expl_html) in tests.test_sklearn_explain_prediction.assert_trained_linear_regression_explained which point that it shoud be 'y' in my case. I am wondering if I missed the point here.
@lopuhin could you please check it?
@qh582 looks good! Would you mind updating a few notes in docs, mentioning this new feature?
- https://github.com/TeamHG-Memex/eli5/blob/master/README.rst
- https://github.com/TeamHG-Memex/eli5/blob/master/docs/source/libraries/lightgbm.rst
- https://github.com/TeamHG-Memex/eli5/blob/master/docs/source/overview.rst
@kmike I think this is ready, please check :)
@kmike Hope the new commit help. My previous piece of code is not strict enough.
It's been two month, could someone tell me why this merge hasn't been closed already? I really need this.
I think PR is in great shape and we just need to check it again and merge it, hope to find time for it soonish, sorry for delay.
Any plans about merging it, @lopuhin?
Thanks you! This were merged in eli5-org/eli5#7 and released to PyPI with v0.11