codestream icon indicating copy to clipboard operation
codestream copied to clipboard

"Go to Definition" does not work in the diff view in vs code

Open MaikKlein opened this issue 3 years ago • 3 comments

"Go to Definition" does not seem to work in the diff mode in vs code. I am not sure if this is an lsp issue or an codestream issue. I did check out the branch locally, if I just open the file I do get all my IDE features like goto definition.

I am using the rust analyzer lsp

2021-05-30-142732_2510x1315_scrot

MaikKlein avatar May 30 '21 12:05 MaikKlein

@MaikKlein unfortunately VS Code doesn’t yet have support for code intelligence inside git diffs. We’ve raised the issue with them in the past and there didn’t seem to be much interest in the idea on their part.

planteater avatar May 30 '21 17:05 planteater

@MaikKlein unfortunately VS Code doesn’t yet have support for code intelligence inside git diffs. We’ve raised the issue with them in the past and there didn’t seem to be much interest in the idea on their part.

You probably already know this, but I do get code intelligence with https://github.com/microsoft/vscode-pull-request-github in the diff view.

2021-06-06-103855_2510x1315_scrot

MaikKlein avatar Jun 06 '21 08:06 MaikKlein

Seems to be that the context menu item shouldn’t be available if it’s going to produce incorrect results.

hgezim avatar Mar 02 '22 01:03 hgezim