AmazeFileManager icon indicating copy to clipboard operation
AmazeFileManager copied to clipboard

[root] treats /data/data as /

Open ildar opened this issue 3 years ago • 5 comments

Describe the bug Navigating to / Root brings to /data/data

To Reproduce Steps to reproduce the behavior:

  1. Tap on / Root
  2. See / on top but the real contents is of /data/data

Expected behavior Show the contents of /

Smartphone (please complete the following information):

  • Device: phhgsi_arm64_ab / AGM H3
  • OS: Android 12 / lineage_arm64_bvS
  • Rooted: [e.g. No]
  • Version: 3.8

Additional context AFM shows /data/data/* contents and a user cannot navigate to .. The possible reason may be the following: the Phh's SU brings to /data/data instead of / as other su implementations:

phhgsi_arm64_ab:/ $ su
:/data/data #

ildar avatar Sep 18 '22 10:09 ildar

So if I understand correctly, it's more of an issue with su binary than of our app.

VishalNehra avatar Sep 18 '22 20:09 VishalNehra

Speaking of Phh's SU binary, Google pointed me to https://github.com/seSuperuser/Superuser which I saw the repo had not been updated for years. Perhaps they are stable enough to survive all Android versions, but I'd wonder why using this when there is a more recent, still developed SU kit, Magisk, available?

I'd recommend you to use that, with busybox module installed via https://github.com/Fox2Code/FoxMagiskModuleManager, and see if it can solve your problem.

I think I'll choose closing this issue.

TranceLove avatar Sep 20 '22 14:09 TranceLove

On Tue, Sep 20, 2022 at 8:52 PM Raymond Lai wrote:

Speaking of Phh's SU binary, Google pointed me to https://github.com/seSuperuser/Superuser which I saw the repo had not been updated for years. Perhaps they are stable enough to survive all Android versions,

This SU Android app is just a yes/no asking interface, nothing really serious to improve.

but I'd wonder why using this when there is a more recent, still developed SU kit, Magisk, available?

The real situation here is quite different. Famous Pierre-Hugues HUSSON aka phhusson develops the GSI ROM that is installable on hundreds of smartphone models. He embeds su into the /system, not to the boot.img. Obviously the different tech. Hence those ROMs are incompatible with Magisk and such. The su binary isn't an outdated piece of software, it is developing and is 100% compatible with Android 12, so noone can call it an abandonware.

I think I'll choose closing this issue.

Please reopen.

ildar avatar Sep 20 '22 15:09 ildar

Is it not just to insert something like:

cmd = "cd /;" + cmd; somewhere here? https://github.com/TeamAmaze/AmazeFileManager/blob/00076315b8b408598bb048687ae0334bd191d4b7/app/src/main/java/com/amaze/filemanager/filesystem/root/base/IRootCommand.kt#L66

ildar avatar Sep 20 '22 15:09 ildar

or getting deeper: what's the point of this? why getting rid of "/" ? https://github.com/TeamAmaze/AmazeFileManager/blob/45e82bfae195249cf1ac36e32843af0fc08d27b8/app/src/main/java/com/amaze/filemanager/filesystem/root/ListFilesCommand.kt#L115

ildar avatar Sep 20 '22 15:09 ildar

No. The problem is that the app assumes that su gives a shell with PWD==/. But that's undefined for Android.

ildar avatar Oct 11 '22 07:10 ildar