AmazeFileManager icon indicating copy to clipboard operation
AmazeFileManager copied to clipboard

Fix for 7z viewer not showing folders

Open DoozyDoz opened this issue 2 years ago • 3 comments

Description

  • Upon opening a 7z compressed file in amaze, only files would be visible despite there existing folders too (as described in issue #3440 )

Issue tracker

Fixes #3440

Automatic tests

  • [ ] Added test cases

Manual tests

  • [x] Done

Build tasks success

Successfully running following tasks on local:

  • [x] ./gradlew assembledebug
  • [x] ./gradlew spotlessCheck

DoozyDoz avatar Sep 02 '22 00:09 DoozyDoz

Please run ./gradlew spotlessApply in local to fix the failing task.

VishalNehra avatar Sep 02 '22 04:09 VishalNehra

Please run ./gradlew spotlessApply in local to fix the failing task.

Done

DoozyDoz avatar Sep 02 '22 06:09 DoozyDoz

Please check following test case failures

java.lang.AssertionError: Thrown from class com.amaze.filemanager.asynchronous.asynctasks.compress.SevenZipHelperCallableTest.name expected:<5> but was:<10>

com.amaze.filemanager.asynchronous.asynctasks.compress.SevenZipHelperCallableTest.testRoot[16] FAILED java.lang.AssertionError: expected:<1> but was:<2>

com.amaze.filemanager.asynchronous.asynctasks.compress.SevenZipHelperCallableTest.testRoot[19] FAILED java.lang.AssertionError: expected:<1> but was:<2>

com.amaze.filemanager.asynchronous.asynctasks.compress.SevenZipHelperCallableTest.testSublevels[19] FAILED java.lang.AssertionError: Thrown from class com.amaze.filemanager.asynchronous.asynctasks.compress.SevenZipHelperCallableTest.name expected:<5> but was:<10>

VishalNehra avatar Sep 02 '22 08:09 VishalNehra

Superceded by #3981.

This PR had been left cold for quite a while with test fixtures didn't get fixed, hence had to make a new changeset based on ideas here.

Thank you again for your work.

TranceLove avatar Nov 08 '23 16:11 TranceLove