AmazeFileManager
AmazeFileManager copied to clipboard
TeamAmaze
Transparent Navigation bar
With dark theme
With light theme
Comparison vs MaterialFiles
Currently we do have Colored Navigation bar option but colors are solid colors. Colored Navigation bar with option to choose from solid/transparent color would be nice. Transparent navigation bar looks modern imo.
Hey, could I work on it if it's open yet. Would be amazed to do so!
Sure.
Thanks for helping out. New to open source by the way. So are you going to make me a contributor or something. Or what do you suggest I should proceed with.
@ashway171 Just fork the repo and you may start right away.
Please base your work on the release/3.7 branch.
@VishalNehra, @TranceLove could you please guide me to what all things I need to take care of while setting up the project locally since I faced a lot of build issues while running it
can you assign me this.
@ashway171 Please confirm if you're still working on this issue. @ANUKULJHA1506 We'll assign you after their confirmation or if there's no reply.
can you assign me this.
@ashway171 Please confirm if you're still working on this issue. @ANUKULJHA1506 We'll assign you after their confirmation or if there's no reply.
Yeah, I'm on it... Just some errors and we are good to go
Hey, is it still open? I would like to work on it!
Yes, and feel free to do!
Hi, I'd like to work on this issue if nobody working on it.
@Trust04zh Sure, please do.
I don't understand what is the issue, can you please explain it? what i have to do ?
I don't understand what is the issue, can you please explain it? what i have to do ?
@Trust04zh is working on this as of now. @mohit-2003 can take this over if @Trust04zh is not working on this anymore.
I'm currently still working on this and try figuring out how to apply transparent navigation bar with the original UI designing, I am not so familiar with Android UI designing, the process may be kinda slow.
@Trust04zh
how to apply transparent navigation bar with the original UI designing
Currently
- when that option is on it follows Primary Color (Left Tab) or Primary Color (Right Tab) color.
- when that option is off it use pure black color (doesn't matter which Theme you pick, even for Material Light theme it's black)
My suggestions
- Keep it as it is.
- [New*] Instead of pure dark change it to transparent
Sorry for not mentioning these details in my comment.
@shuvashish76 Thank you for your patient explanation!
I noticed the facts just as you describe about the current behaviors (also I think the behavior when turning off may not be as expected, as the original color is not always black, this might be another issue), while I wonder if it would be better to add an independent option for setting transparent navigation bar, as the "Colored Navigation Bar" setting sounds not for setting the navigation bar to be transparent or not, I think.
So I think there might be another checkbox below "Colored Navigation Bar" to set the navigation bar to be transparent, I would be thankful if you could share your opinion with me.
And What I'm currently figuring out is about the code implementation for this feature, simply set an transparent argb color with api Window.setNavigationBarColor won't set a truly transparent color, and I'm reading references and testing to let it work.
the behavior when turning off may not be as expected
Agreed, but for example by default Material Files show transparent navigation bar & no special settings to turn that off/on. So why not follow same behaviour for Amaze (off/transparent by default)?
better to add an independent option for setting transparent navigation bar
- I like Amaze's minimal & organised settings & IMO another setting just for that is unnecessary.
- Ok what would be the navigation bar color for Amaze, if you turn off both
Colored Navigation bar&Transparent Navigation bar? Black?
Sorry for my late reply.
Ok what would be the navigation bar color for Amaze, if you turn off both Colored Navigation bar & Transparent Navigation bar? Black?
System default color, white for light theme while black for dark theme, which are the colors you launch Amaze with corresponding system theme and with Colored Navigation bar disabled, I guess this might be the expected behavior than simply black.
I like Amaze's minimal & organised settings & IMO another setting just for that is unnecessary.
I agree that another option can be unnecessary, while I'm not sure if it is ok if there's no option for "solid and system default navigation bar color".
some report for my process:
I implemented transparent navigation bar by modifying styles so that navigation bar color become transparent, and enabled some flags to allow views to draw under system bars, but I still need to specify what should be drawn under system bars and what should not, or it will simply be like this.
I've found some advises about using windowInsets to control the layout to solve this, also I read some source code of MaterialFiles and it seems that it use windowInset and padding to control the layout, while I didn't finish it yet.
@VishnuSanal
No, I didn't find an easy approach to implement this feature.
Two references that maybe helpful:
For transparent system bars
https://medium.com/androiddevelopers/gesture-navigation-going-edge-to-edge-812f62e4e83e
For only draw behind status bar (so can navigation bar)
https://stackoverflow.com/questions/68451704/transparent-status-bar-with-visible-navigation-bar#68492550