All-of-Fabric-6 icon indicating copy to clipboard operation
All-of-Fabric-6 copied to clipboard

MI Pipes and cables break on being moved by Create contraptions

Open finleyaubin opened this issue 1 year ago • 0 comments

Description

Upon moving a Mi pipe/pipe network with the Create mod, pipes physical positions become unlinked with their positions in the network, leading to situations where blocks where the pipes once were, now contain a "ghost pipe" which cannot be removed without the use of commands, and still more of the same type of pipe cannot be placed into these locations and neighbouring pipes will still class these as pipes and try to connect.

To Reproduce

  1. create a pipe or cable network with MI to transport fluids or energy to machines
  2. superglue the network together
  3. push the network with a mechanical piston
  4. try to place the same pipes you used in the network on their starting positions, and observe that it doesn't work and this message is posted to the log:

[Server thread/ERROR]: Failed to handle packet net.minecraft.class_2885@7e782299, suppressing error java.lang.IllegalArgumentException: Cannot add a node that is already in the network. at aztech.modern_industrialization.pipes.api.PipeNetworkManager.addNode(PipeNetworkManager.java:253) ~[Modern->Industrialization-1.6.9.jar:?] at aztech.modern_industrialization.pipes.impl.PipeBlockEntity.addPipe(PipeBlockEntity.java:174) ~[Modern-Industrialization-1.6.9.jar:?] at aztech.modern_industrialization.pipes.impl.PipeItem.tryPlaceAt(PipeItem.java:133) ~[Modern-Industrialization-1.6.9.jar:?] at aztech.modern_industrialization.pipes.impl.PipeItem.tryPlace(PipeItem.java:113) ~[Modern-Industrialization-1.6.9.jar:?] at aztech.modern_industrialization.pipes.impl.PipeItem.method_7884(PipeItem.java:63) ~[Modern-Industrialization-1.6.9.jar:?] at net.minecraft.class_1799.method_7981(class_1799.java:264) ~[server-intermediary.jar:?] at net.minecraft.class_3225.method_14262(class_3225.java:358) ~[server-intermediary.jar:?] at net.minecraft.class_3244.method_12046(class_3244.java:1145) ~[server-intermediary.jar:?] at net.minecraft.class_2885.method_12547(class_2885.java:34) ~[server-intermediary.jar:?] at net.minecraft.class_2885.method_11054(class_2885.java:8) ~[server-intermediary.jar:?] at net.minecraft.class_2600.method_11072(class_2600.java:22) ~[server-intermediary.jar:?] at net.minecraft.class_3738.run(class_3738.java:18) ~[server-intermediary.jar:?] at net.minecraft.class_1255.method_18859(class_1255.java:157) ~[server-intermediary.jar:?] at net.minecraft.class_4093.method_18859(class_4093.java:23) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:776) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:159) ~[server-intermediary.jar:?] at net.minecraft.class_1255.method_16075(class_1255.java:131) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:758) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:752) ~[server-intermediary.jar:?] at net.minecraft.class_1255.method_5383(class_1255.java:116) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:736) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:669) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257) ~[server-intermediary.jar:?] at java.lang.Thread.run(Thread.java:833) [?:?]

  1. try placing the pipe into a neighbouring block, and see that it tries to connect to the ghost block

Expected behavior

the pipes will work as usual after being moved and not create ghost blocks, or MI pipes are immovable by the Create mod like they are with pistons.

Priority

Medium

Screenshots/Video

image

Affected Version

1.9.1

finleyaubin avatar Aug 16 '23 21:08 finleyaubin