Teagan King

Results 188 comments of Teagan King

Thanks for addressing some of these comments! I made issue ticket #140 for the empty slice error-- that's fine by me to address in another PR as long as the...

Hey @nmizukami , thanks for these updates. Not all notebooks are comparing with observations, but you can see an example of an observational comparison in the glacier notebook & corresponding...

And I'll review after our discussion on Thursday.

The key setup here that's different from the coupled-model example is in the ['global params' section of the config file](https://github.com/NCAR/CUPiD/blob/54de63cbe03696a278c9fcd5fa5c96ee7ad092c6/examples/key_metrics/config.yml#L47), where we have both a case name for the case...

That sounds good that plots are generated without obs if obs do not exist.

@nmizukami is planning to do the following: - [x] implement comparison with base_case in addition to obs - [x] remove years that overwrite config file start/end years - [x] include...

Hey @nmizukami , thanks for all your work on this! It's definitely getting much closer! I made a few in-line comments above and also wanted to remind you of @mnlevy1981...

It looks like the notebooks ran in `key_metrics` in about 15 minutes. Both notebooks seem to be running smoothly. One additional comment regarding the figures-- in `month_annual_flow.ipynb`, there are a...