TcOpen icon indicating copy to clipboard operation
TcOpen copied to clipboard

Published 20 hours ago • verified publisher icon TcOpenGroup

Implicit conversion warnings from TcOSequencerBase

Open github-actions[bot] opened this issue 2 years ago • 3 comments

closes #404

github-actions[bot] avatar Apr 25 '22 15:04 github-actions[bot]

I was chasing also other warnings from cs projects in this PR.

PTKu avatar Apr 27 '22 04:04 PTKu

Hi Peter! Thanks for picking this up so quickly.

I added a few comments. More in general, there are lots of changes. Are all directly relevant to close the issue?

rruiter87 avatar Apr 27 '22 06:04 rruiter87

Hi @rruiter87, I focused only on removing warnings from the TcoCore in general. There were some warnings related to obsoletes in C# parts of the library and some to missing translations across the library for the languages that are already implemented. To make the long story short I widened the scope of the issue to remove some warnings also from non PLC parts of the library. @TomKovac will have a look at the TcoSequencers methods... there is some acrobatics with the numeric types...

PTKu avatar Apr 27 '22 15:04 PTKu