TcOpen icon indicating copy to clipboard operation
TcOpen copied to clipboard

Implicit conversion warnings from TcOSequencerBase

Open rruiter87 opened this issue 2 years ago • 3 comments

There are several implicit conversion warnings as shown below. For example

// line 59
_message := CONCAT('ERROR NOT UNIQUE STEP_ID ',UINT_TO_STRING(inStepID));

where inStepID is actually an INT.

Solutions

  1. change UINT_TO_STRING to INT_TO_STRING
  2. change UINT_TO_STRING to more general TO_STRING

All warnings:

image

Severity Code Description Project
Warning Implicit conversion from signed Type 'INT' to unsigned Type 'UINT' : possible change of sign [tcocore, 0.5.0.834 (vortex.library)] TcoSequencerBase.IsStepIdUnique 59
Warning Implicit conversion from signed Type 'SINT' to unsigned Type 'UINT' : possible change of sign [tcocore, 0.5.0.834 (vortex.library)] TcoSequencerBase.StepInternal 34
Warning Implicit conversion from unsigned Type 'UINT' to signed Type 'INT' : possible change of sign [tcocore, 0.5.0.834 (vortex.library)] TcoSequencerBase.StepInternal 140
Warning Implicit conversion from unsigned Type 'UINT' to signed Type 'INT' : possible change of sign [tcocore, 0.5.0.834 (vortex.library)] TcoSequencerBase.StepInternal 140
Warning Implicit conversion from signed Type 'INT' to unsigned Type 'UINT' : possible change of sign [tcocore, 0.5.0.834 (vortex.library)] TcoSequencerBase.StepInternal 150
Warning Implicit conversion from signed Type 'INT' to unsigned Type 'UINT' : possible change of sign [tcocore, 0.5.0.834 (vortex.library)] TcoSequencerBase.StepInternal 152
Warning Implicit conversion from unsigned Type 'UINT' to signed Type 'INT' : possible change of sign [tcocore, 0.5.0.834 (vortex.library)] TcoSequencerBase.StepInternal 158
Warning Implicit conversion from unsigned Type 'UINT' to signed Type 'INT' : possible change of sign [tcocore, 0.5.0.834 (vortex.library)] TcoSequencerBase.StepInternal 158
Warning Implicit conversion from signed Type 'INT' to unsigned Type 'UINT' : possible change of sign [tcocore, 0.5.0.834 (vortex.library)] TcoSequencerBase.StepInternal 159
Warning Implicit conversion from signed Type 'INT' to unsigned Type 'UINT' : possible change of sign [tcocore, 0.5.0.834 (vortex.library)] TcoSequencerBase.StepInternal 161

rruiter87 avatar Apr 22 '22 09:04 rruiter87

good point @rruiter87, been on my list for some time will have a look

/create_issue_branch

PTKu avatar Apr 25 '22 15:04 PTKu

/cib

PTKu avatar Apr 25 '22 15:04 PTKu