Advanced-R-Solutions icon indicating copy to clipboard operation
Advanced-R-Solutions copied to clipboard

re written chapter 25 + renders with quarto

Open pachadotdev opened this issue 1 year ago • 5 comments

Hi @hadley @Tazinho @henningsway !

As I mentioned to Hadley, I was interested in working on chapter 25, to which he agreed

I have uninstalled R completely, and then tried to render the book adding one dependency to imports at a time. Then I made multiple changes to make it work with Quarto, which works well with the HTML, but not with the PDF (unless I set some chunks that I commented in the commits list to eval = F)

pachadotdev avatar Jan 24 '24 16:01 pachadotdev

Thanks @pachadotdev, this looks very good. Looking forward to @Tazinho perspective. :)

Regarding the Netlify deployment, we'd have to adjust https://github.com/Tazinho/Advanced-R-Solutions/blob/main/.github/workflows/bookdown.yaml as well.

henningsway avatar Feb 11 '24 13:02 henningsway

Thanks @pachadotdev, this looks very good. Looking forward to @Tazinho perspective. :)

Regarding the Netlify deployment, we'd have to adjust https://github.com/Tazinho/Advanced-R-Solutions/blob/main/.github/workflows/bookdown.yaml as well.

good point! this is a complex project, one that would serve a very good purpose for a posit blog post about "rmarkdown to quarto" corner cases

pachadotdev avatar Feb 11 '24 20:02 pachadotdev

@pachadotdev thank you very much for your contribution. I haven't yet looked through the content, but in general I am fine with an update. However, I guess the biggest challenge is the technical setup for now. Am I correct that we could just go with the following steps?

  1. Bring the old version to some new branch within our repository, e.g. "AVDRS-E1-2021" (including the instruction for the PDF rendering - just to be clean and not lose it)
  2. Merge your Quarto Version on the main branch? (PDF is not needed as there is no 2nd edition planned)
  3. Make the Quarto Version work with Netlify

Tazinho avatar Mar 02 '24 09:03 Tazinho

@pachadotdev thank you very much for your contribution. I haven't yet looked through the content, but in general I am fine with an update. However, I guess the biggest challenge is the technical setup for now. Am I correct that we could just go with the following steps?

1. Bring the old version to some new branch within our repository, e.g. "AVDRS-E1-2021" (including the instruction for the PDF rendering - just to be clean and not lose it)

2. Merge your Quarto Version on the main branch? (PDF is not needed as there is no 2nd edition planned)

3. Make the Quarto Version work with Netlify

@Tazinho happy to, I could not find a "good" way to render the site as is let me ask the Quarto experts to find a way to render the PDF in a way that is reasonable the other option is to restore the old branch, and there paste the new DESCRIPTION and the Qmd/Rmd chapter I edited

pachadotdev avatar Mar 04 '24 01:03 pachadotdev

@Tazinho I just pushed changed to the GH-Actions that render with Quarto and publish with Netlify

pachadotdev avatar Mar 06 '24 18:03 pachadotdev