TaxoPress icon indicating copy to clipboard operation
TaxoPress copied to clipboard

Allow TaxoPress widget to support heirarchy view

Open stevejburge opened this issue 3 years ago • 19 comments

The default "Categories" widget / block has a "Show hierarchy" feature Screen Shot 2021-11-29 at 12 56 01 PM

We should make that possible also. The setting should appear if "List UL/LI" is selected

Screen Shot 2021-11-29 at 12 57 13 PM

stevejburge avatar Nov 29 '21 17:11 stevejburge

@stevejburge this issue is refering to "Terms Display" settings output and where again, what's the name of the widget you screenshot ?

ojopaul avatar Dec 02 '21 14:12 ojopaul

@ojopaul this our widget here: Screen Shot 2021-12-02 at 9 41 13 AM

stevejburge avatar Dec 02 '21 14:12 stevejburge

@stevejburge , while working on this, i discovered "Terms Display" actually show terms/tags and not taxonomy/category that has hierarchy feature. So, how's hierarchy suppose to work since it's not listing taxonomy/category or i didn't understand the feature fully ?

cat

ojopaul avatar Dec 03 '21 13:12 ojopaul

@ojopaul Yes, that's the default, but you can change that setting to use Categories instead: Screen Shot 2021-12-03 at 12 06 46 PM

stevejburge avatar Dec 03 '21 17:12 stevejburge

You still doesn't get what i was trying to point out. Check my attached screenshot. Category is showing taxonomy which has hierarchy feature and terms display is showing terms which doesn't have such feature.

Terms doesn't have hierarchy feature.

@stevejburge

ojopaul avatar Dec 03 '21 17:12 ojopaul

Oh, i understood you now. I was checking tags. I think the main problem here is, most taxonomy are like post_tags that doesn't have hierarchy options. Reason why i wasn't getting it before.

Will check now testing with category @stevejburge

ojopaul avatar Dec 03 '21 17:12 ojopaul

For example, media_tags from your screenshot doesn't have 'hierarchy' feature like category.

ojopaul avatar Dec 03 '21 17:12 ojopaul

So, that means this feature will only works in taxonomy that has child parent relationship.

ojopaul avatar Dec 03 '21 17:12 ojopaul

@ojopaul Sorry, some of this is a bit confusing

My categories:

Screen Shot 2021-12-03 at 12 14 38 PM

My settings:

Screen Shot 2021-12-03 at 12 16 14 PM

Output from the TaxoPress widget, with no hierarchy:

Screen Shot 2021-12-03 at 12 16 23 PM

stevejburge avatar Dec 03 '21 17:12 stevejburge

Yes, i got it now. I was having issues before because this feature won't work for some taxonomy that doesn't have parent child relationship.

For example, post_tags, media_tags etc

ojopaul avatar Dec 03 '21 17:12 ojopaul

Good point. Maybe there should be a setting?

"Show hierarchy? (if applicable)"

stevejburge avatar Dec 03 '21 17:12 stevejburge

Yes, make sense

ojopaul avatar Dec 03 '21 17:12 ojopaul

@stevejburge i'm not able to implement this feature due to ways terms display is implemented.

It's not same process as just retrieving terms same way the screenshot category is done. Tracing the source code, i noticed the main feature is tag cloud which pass though various configurations that make hierarchy impossible some and not limited to (1.) Timeframe limit(based on if a category is used and this filter is done while query tags), (2.) method (which could be random, alphabetical etc) among others. I tried changing the function when hierarchy is selected for terms display but i realised some features/user configuration are lost in the process.

If we think this through, this feature is not suitable for terms display unless we want to ignore some of the settings when hierarchy is selected and simply query same way as normal category is done.

ojopaul avatar Dec 07 '21 08:12 ojopaul

OK, thanks @ojopaul

I appreciate the detailed explanation

Let's hold this for next milestone which will have a big redesign for Terms Display

stevejburge avatar Dec 07 '21 19:12 stevejburge

There's no more issue on this milestone, should I send the package or wait for more issues to be added?

On Tue, Dec 7, 2021, 8:21 PM Steve Burge @.***> wrote:

OK, thanks @ojopaul https://github.com/ojopaul

I appreciate the detailed explanation

Let's hold this for next milestone which will have a big redesign for Terms Display

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TaxoPress/TaxoPress/issues/1109#issuecomment-988202528, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV622EKUAJIQDOJBCHRKDJLUPZNFDANCNFSM5I7X3EFA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ojopaul avatar Dec 07 '21 19:12 ojopaul

Sure, let's do it

Steve

On Tue, Dec 7, 2021 at 2:29 PM ojopaul @.***> wrote:

There's no more issue on this milestone, should I send the package or wait for more issues to be added?

On Tue, Dec 7, 2021, 8:21 PM Steve Burge @.***> wrote:

OK, thanks @ojopaul https://github.com/ojopaul

I appreciate the detailed explanation

Let's hold this for next milestone which will have a big redesign for Terms Display

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/TaxoPress/TaxoPress/issues/1109#issuecomment-988202528 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AV622EKUAJIQDOJBCHRKDJLUPZNFDANCNFSM5I7X3EFA

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TaxoPress/TaxoPress/issues/1109#issuecomment-988207202, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5QK7F4LE7FUJBVQCSKZ73UPZOCNANCNFSM5I7X3EFA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

stevejburge avatar Dec 07 '21 19:12 stevejburge

@stevejburge have you decided for the way forward on this considering the fact it's in an active work milestone ?

ojopaul avatar Feb 08 '22 13:02 ojopaul

@ojopaul I think we should do this

If we do this, should we disable the "Timeframe limit" and "Method" options?

stevejburge avatar Feb 08 '22 19:02 stevejburge

@stevejburge , i've checked this again but won't be able to predict what'll work or won't work when 'heirarchy' is enabled.

Here's traditional wordPress term query parameters https://developer.wordpress.org/reference/classes/WP_Term_Query/__construct/ and any feature outside the accepted parameters, i'll only be able to determine if they'll work or not or if i'll be able to find way to make them work or not during development.

So, if this is really necessary, then we can make this to be exclusive to terms that support heirarchy (like category) and not those that are not supporting heirarchy like (tags) when UL/LI format is selected.

So, may not be able to give accurate replies on features that'll be lost in all the Terms Displays settings until i started working and try first.

ojopaul avatar Feb 09 '22 14:02 ojopaul