PlexTraktSync icon indicating copy to clipboard operation
PlexTraktSync copied to clipboard

Change the default behavior of the executable

Open agneevX opened this issue 3 years ago • 4 comments

By default, plextraktsync runs sync.

This should not happen because:

  1. sync is already a subcommand
  2. sync is needed to use further arguments, e.g. plextraktsync --sync movies doesn't work, plextraktsync sync --sync movies does
  3. It could be unintentional (destructive) as the user could be exploring available commands

It should simply show plextraktsync --help options and exit. This way when a command is specified, it is explicit and intentional by the user.

agneevX avatar Feb 05 '22 14:02 agneevX

It might be too early morning, but what is the suggestion here?

glensc avatar Feb 06 '22 09:02 glensc

It should simply show plextraktsync --help options and exit.

Basically a subcommand should always be specified for it to work.

agneevX avatar Feb 06 '22 10:02 agneevX

Probably should first add a warning message that the default command is going away.

glensc avatar Feb 06 '22 11:02 glensc

Probably should first add a warning message that the default command is going away.

I agree requiring an argument is drastically better behavior, but this is a breaking change that no matter how much warning time is given, people will not notice until failure. The question becomes, what is the cost/benefit?

I am not suggesting this, but an alternate idea would be to make plextraktsync be an alias of newcommand sync.

My initial instinct would be to make the new command plextrakt but as that is not the name of the project, it is a very poor naming convention, so it likely is not any better than the current behavior.

trex005 avatar Feb 16 '22 22:02 trex005

Adding warning:

  • https://github.com/Taxel/PlexTraktSync/pull/1265

add your 👍🏿 or review submission

glensc avatar Dec 08 '22 07:12 glensc