Tatu Lund comments

Results 232 comments of


                                            Tatu Lund

GridPro: Enable edit mode in custom editors with keypress

Also related/duplicate https://github.com/vaadin/web-components/issues/2536

Number field fires spurious value change events when assigning a value that cannot be parsed

A bit more distant cousin here: https://github.com/vaadin/hilla/issues/2185

Combobox loses value when doing setItems with identical items set

What behavior you want really depends on the application. The current behavior is quite natural default as it more likely that new data set does not have the value than...

TreeGrid does not or not reliably scroll to an item, or expand its nodes from the root to an item. See video.

I think you use wrong scrollToIndex method in the code, see: https://vaadin.com/docs/next/components/tree-grid#programmatic-scrolling

treeGrid.getDataProvider().refreshAll() annoyingly scrolls to the start. See video.

Looks like duplicate of: https://github.com/vaadin/flow-components/issues/1236

treeGrid.getDataProvider().refreshAll() annoyingly scrolls to the start. See video.

With the following change issue goes away Replace Button code with: ``` Button button = new Button("Revalidate!", e -> refreshChildItems(treeGrid, treeData.getRootItems())); ``` And add recursive refreshItem method ``` private void...

Dialogs are not closed on view change

IMHO if we change this, it would require API for application developer to decide how a specific Dialog instance should be behaving in their specific application. E.g. if you would...

clear() should be overriden by all test bench elements, that do not support it natively

See also: https://github.com/vaadin/testbench/issues/1800

Support for ElementQuery.caption()

The case with fields when there is only a textual label is the simplest. One can use "label" property then. This is trivial. ``` TextFieldElement nameField = $(TextFieldElement.class).all().stream() .filter(elem ->...

Support for ElementQuery.caption()

Then my recommendation is to add id to components in the Java code and use id selector in TestBench, that will use css selector with attribute and it will be...