Tarek Hassan

Results 43 comments of Tarek Hassan

Thank you @cosimoNigro for those use cases, they are indeed valid cases to be considered for discussion. I remember some of these were discussed in the past when defining DL3...

Hi @MaxNoe This is essentially https://github.com/open-gamma-ray-astro/gamma-astro-data-formats/issues/30. The thing is that it is hard to be consistent, given that `ENERGY` within the IRFs refers to the true energy, while within the...

@MaxNoe I think calculating IRFs needs DL2, not DL3. So @jknodlseder is right that it might be slightly out of scope regarding that specific science case. But there are probably...

> As the only difference between DL2 and DL3 is the added IRFs, this does not matter for the event list format, it would be the same for DL2 and...

Yes, overlapping bins require the two arrays. This should not be changed.

Just to prolong the discussion... I agree with @javierrico with the fact that current definitions are not optimal. Although I would definitely not use pointing direction. In full-enclosure IRFs, each...

> I agree with @TarekHC for the last part but pointlike IRF are also stored over the whole FoV (here what is called THETA in the DL3 format). For example...

Yes, @JouvinLea is right: only the PSF is stored vs offset. I don't consider the background an IRF. It is a model, and the fact that is included here is...

@jknodlseder : is "the IRF is computed as a function of true energy and source position" really correct? The PSF is not computed as a function of the source position,...

Hi @jknodlseder, * Do you propose to just remove the "via a 3D analysis (1D in energy, 2D in direction)"? * Or do you propose to change "the IRF is...