taraxa-node icon indicating copy to clipboard operation
taraxa-node copied to clipboard

Link conan libraries depending on project build type

Open kstdl opened this issue 4 years ago • 1 comments

Is your feature request related to a problem? Please describe.

For now all conan libraries in linked statically not depending on project build type. I think we should build conan libraries shared for all libraries we can and use them for project shared build. At least one thing we can not build shared is rocksdb that provides only C API for shared library because of this lines from its conanfile:

            if self.options.shared:
                self._remove_cpp_headers() # Force stable ABI for shared libraries

Describe the solution you'd like.

Project build type should be considered for conan libraries. So we need to set it somehow. For example for conan-cmake properties could be passed from a cmake file

kstdl avatar Oct 12 '21 10:10 kstdl

@kstdl Isn't this already done ?

JakubFornadel avatar Jan 14 '22 14:01 JakubFornadel