Daijishou icon indicating copy to clipboard operation
Daijishou copied to clipboard

Expand to cutout area

Open German-Herrador opened this issue 1 year ago • 1 comments

Add a full screen mode option to mobile devices with notch.

German-Herrador avatar Jul 25 '22 14:07 German-Herrador

Or a pure black theme, really. Just so that the cutout area isn't as visible.

bkcin avatar Oct 03 '22 00:10 bkcin

A pure black theme will be introduced in 1.4.10.

TapiocaFox avatar Mar 11 '23 18:03 TapiocaFox

A pure black theme is not a true solution, i created some illustrations to explain the issue. I made a white background with a red line right in the center and then i added it to the launcher. Then i took a screenshot of me inside the launcher and put a blue line in the REAL center of my screen. This way you can see that since the app doesn't display in where the notch is it's out of center. If the app displayed in all the screen then the two lines would have aligned.

Picsart_23-03-11_16-09-49-762

This is because the red part marked in this image is just black screen not being used, a pure black theme wouldn't solve the problem because it doesn't have to do anything with it. Picsart_23-03-11_16-18-04-998

Maybe i misunderstood how the pure black theme would have fixed the issue but the problem with not having full screen display is that there's a part of the screen not being used resulting in the effect that the launcher is out off center.

German-Herrador avatar Mar 11 '23 22:03 German-Herrador

But if Dai expanded to the cutout area. Doesn't that also crop the UI of Dai? 🤔

TapiocaFox avatar Mar 11 '23 23:03 TapiocaFox

The way you made the Launcher is perfect because nothing would be behind the notch out of reach. Several games have full screen display like Asphalt 9 and there's no problem with it. You're loosing more screen space by ignoring the notch than you will loose with the space the notch takes from the UI. Also adding the fact that it's out of center.

Here's a gameplay of an app in full screen display: https://youtu.be/aTkHK5zV2SM

German-Herrador avatar Mar 11 '23 23:03 German-Herrador

But if Dai expanded to the cutout area. Doesn't that also crop the UI of Said? 🤔

在有些app里会出现这种情况(如Retroarch,边缘元素有时候会被遮挡)。 但是如PPSSPP,全屏显示,主要UI元素会居中(如游戏画面),但是边缘元素会避开缺口部分(如按键)。

下附PPSSPP,屏幕打孔分别在右、左侧时UI位置的区别,但背景始终为全屏显示 Screenshot_20230312_100542_PPSSPP.png

Screenshot_20230312_100538_PPSSPP.png

Screenshot_20230312_100950_PPSSPP.png

Screenshot_20230312_100957_PPSSPP.png

在Dai中,我也认为主要画面居中(如模拟器封面),观感会更好。

bkcin avatar Mar 12 '23 02:03 bkcin