scaerospike icon indicating copy to clipboard operation
scaerospike copied to clipboard

prevent from NPE, add a multi get returning list of pair of (key maps)

Open worldline-messaging opened this issue 10 years ago • 1 comments

if(rec.bins!=null) { to prevent from NullPointerException ( you can pass an empty set as parameter of the query )

multiQueryL is better when you want to keep the order of the keys passed as parameter. With a map you loose the order in the result.

For the WriteSettings, i prefere to send key by default.

Blocking is just a question of choice.

worldline-messaging avatar Feb 06 '15 13:02 worldline-messaging

That null check actually seems to be necessary - should probably have been spelled out in their docs that they simply return a null instead of an empty collection in case you request no bins. I think it makes more sense to add a method that takes a CanBuildFrom instead of a concrete List instance.

soro avatar Feb 09 '15 18:02 soro