MinimalNugetServer
MinimalNugetServer copied to clipboard
TanukiSharp
Docker?
If not, I recommend setting an image up. Maybe use Travis CI to build it.
Excuse me, could you elaborate please? What you are talking about sounds is a bit vague to me ^^
Sounds like a request to provide a docker image for this server - which I would also like to see.
I've been trying to create a Dockerfile but it seems the project strangely require .NET core 1.0.5 to publish. The project shouldn't require .NET core 1.0.5 because it is not declared anywhere in the project.
After some inspection, I suspect GitCommitInfo (which required .NET core 1.0.5 to run) is the culprit. Do you have any input on this? @TanukiSharp
If I can sort this out, perhaps we can pull off a docker image for this good package.
Sorry for very late reply. I'm quite busy lately and will still be until mid/end of November. Actually GitCommitInfo has bugged me several times on different projects, and most of the time I simply stopped using it, making me blind on which commit is published, but at least I can publish.
So if it bothers you, remove it from your fork. I may consider to remove it as well.
If that's the case, then I'll create 2 PRs, one for removing GitCommitInfo and another one for the Dockerfile to keep the topic separated.
Hi,
I forked the project, got the docker file to work and added travis ci for automated build of the CI. Will let you know how the testing of the docker image goes.
Branch https://github.com/rolfwessels/MinimalNugetServer/tree/feature/add_docker_build_scripts Travis Ci Build https://travis-ci.org/rolfwessels/MinimalNugetServer
Will do a PR back when it's all integrated.
