tanuki.py icon indicating copy to clipboard operation
tanuki.py copied to clipboard

Replace the `dict` response in `load_existing_datasets` with a Pydantic class

Open JackHopkins opened this issue 1 year ago • 4 comments

We should avoid passing loosely typed dictionaries around if we can avoid it. This should be replaced by a Pydantic class.

Note: This is in BufferedLogger.

JackHopkins avatar Nov 24 '23 05:11 JackHopkins

Hi! I'm pretty new to Python and was looking for good first issues to tackle.

Was curious to know why you would use a Pydantic class here rather than a simple dataclass for this?

cosmastech avatar Nov 24 '23 14:11 cosmastech

Hey @cosmastech, a simple dataclass could work just as well!

If you're looking to contribute - awesome! I can create a couple of issues that are good starter issues to get to grips with the codebase.

I'll tag you in them when I've put them up.

JackHopkins avatar Nov 25 '23 11:11 JackHopkins

Hey @cosmastech, a simple dataclass could work just as well!

If you're looking to contribute - awesome! I can create a couple of issues that are good starter issues to get to grips with the codebase.

I'll tag you in them when I've put them up.

Cool! Thanks.

cosmastech avatar Nov 25 '23 11:11 cosmastech

Could you please have a look at this one? @cosmastech

JackHopkins avatar Nov 25 '23 11:11 JackHopkins