material-intro-screen icon indicating copy to clipboard operation
material-intro-screen copied to clipboard

Translatable permissions buttons

Open aexvir opened this issue 9 years ago • 7 comments

Could this option be added? It's strange to have the whole application in one language and the buttons always in english.

Maybe the translation string could be passed as a second option to the neededPermissions and possiblePermissions methods.

Many thanks!

aexvir avatar Jan 04 '17 17:01 aexvir

Good idea, we'll add that to todo list. ;)

bezmian avatar Jan 04 '17 17:01 bezmian

@bezmian Thanks! :)

aexvir avatar Jan 05 '17 09:01 aexvir

We also need this feature. Please try to include it into the next release. Thanks.

volvciklum avatar Jan 05 '17 17:01 volvciklum

Also faced this one. Would love it to be added.

xp-vit avatar Jan 24 '17 10:01 xp-vit

@proudh0n @volvciklum @xp-vit

For now you can simply override grant_permissions ( mis_grant_permissions in the upcoming 0.0.6 version). But we can't guarantee that we will not change this string resource name in future it is not recommended solution.

However, in next 0.0.6 we will provide:

  • possibility to set default permission button text ( @StringRes ) on MaterialIntroActivity
  • possibility to override default permission button text on each slide ( @StringRes ) using SlideFragmentBuilder
  • library by default will use grant_permissions ( mis_grant_permissions since 0.0.6 version) string resource

@proudh0n @volvciklum @xp-vit it would be great if you could add translations for default grant_permissions text in your languages and create some PRs ;). It will be much easier for other library users if it will have default translations out of the box ;)

So guys what do you think about it?

Cheers!

radzio avatar Feb 02 '17 12:02 radzio

@radzio Of course, I'll translate the strings as soon as possible. Many thanks for implementing the feature

aexvir avatar Feb 08 '17 15:02 aexvir

Could this issue be merged/closed during next 1-2 weeks? Any chance?

volvciklum avatar Apr 12 '17 10:04 volvciklum