recipes
recipes copied to clipboard
TandoorRecipes
Ingredient Notes Rework
Is your feature request related to a problem? Please describe. It's kind of a pain when cooking to hover over the comment icon to see the note.
Describe the solution you'd like It would be cool to have notes that are under x amount of characters just display text. For example, if you just want to specify "softened" for butter, then it would just show up as "butter, softened". But if you want to say something longer, like "Make sure the bananas are very ripe", then the current hover system would be used.
Describe alternatives you've considered Text wrapping could also be a viable solution. Maybe a user setting that will toggle between hovering and wrapping.
Additional context Mostly a QoL feature, but for me, the minimal amount of interaction I can make with the computer while cooking, the better.
Example:
this is a cool idea, i have a big mix of long and short notes as well .. it coudl also be a setting i guess 🤔 definitely something i want to do
i will look at both of those options when i get to this, thanks for the link
@smilerz Do you need any help or assistance ? I can help you out if you are interested
Feel free to give it a try, it's not super complicated but the solution needs to be well thought trough.
Hi @vabene1111 I will try to solve it and also I have joined the discord server.Hope you and other people will help me and support. Since this is my first open source contribution please help me out if I need any help.
Sure, feel free to ask. Also please share a rough draft of what you want to do before implementing anything.
Hello, @hotdog218 I can work on this issue, could you please assign it to me?
Hello, @hotdog218 I can work on this issue, could you please assign it to me?
I don't believe I have the ability to assign anything, plus I think @pedro-camargo11 is already handling this- thanks by the way!
Hello, @hotdog218 I can work on this issue, could you please assign it to me?
No need to have it assigned to you. If you have thoughts on how to address you can describe your solution here. Or submit a PR and it’ll be reviewed for merge.
somebody opened a PR here https://github.com/TandoorRecipes/recipes/pull/2643
There's already an open PR for this, but I suppose if you wanted to make it a setting that is still something that could be done given that the PR has been open for a while.
Actually this is my first time trying to do an open source not having any prior idea. Can you please suggest what should I do?
On Wed, 13 Dec, 2023, 11:32 pm Zach, @.***> wrote:
There's already an open PR for this, but I suppose if you wanted to make it a setting that is still something that could be done given that the PR has been open for a while.
— Reply to this email directly, view it on GitHub https://github.com/TandoorRecipes/recipes/issues/455#issuecomment-1854461408, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5AQXK7POUGAABJSGYNTBGDYJHUSVAVCNFSM4YDORPWKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBVGQ2DMMJUGA4A . You are receiving this because you commented.Message ID: @.***>
Actually this is my first time trying to do an open source not having any prior idea. Can you please suggest what should I do?
do you know python or vue?
I am sorry to say tha I know none of the two.
On Thu, 14 Dec, 2023, 12:05 am smilerz, @.***> wrote:
Actually this is my first time trying to do an open source not having any prior idea. Can you please suggest what should I do?
do you know python or vue?
— Reply to this email directly, view it on GitHub https://github.com/TandoorRecipes/recipes/issues/455#issuecomment-1854508174, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5AQXK7WR33Z4CICNSTEEJDYJHYPZAVCNFSM4YDORPWKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBVGQ2TAOBRG42A . You are receiving this because you commented.Message ID: @.***>
I am sorry to say tha I know none of the two.
Contributing to this project probably isn't for you then.
Ok, thanks anyway.
On Thu, 14 Dec, 2023, 12:11 am smilerz, @.***> wrote:
I am sorry to say tha I know none of the two.
Contributing to this project probably isn't for you then.
— Reply to this email directly, view it on GitHub https://github.com/TandoorRecipes/recipes/issues/455#issuecomment-1854516175, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5AQXK7MHLRZVIO2FNDOZTTYJHZFJAVCNFSM4YDORPWKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBVGQ2TCNRRG42Q . You are receiving this because you commented.Message ID: @.***>
I'd argue that the view page should not be a table but a list or a two column table with the green check mark(I don't know what it's for) and the ingredient with the note separated by a comma. It's standard on the recipe sites I frequent.
like so: (ignore the missing checkmark)
with something like this (I can optimize this later):
displayIngredient: function(){
let result = ""
if(this.amount)
result += this.amount
if(this.unitName)
result += " "+ this.unitName
result += " " + this.foodName
if(this.ingredient.note)
result += ", " + this.ingredient.note
return result
}
Let me know if you feel this is out of scope for this ticket. It would be much more usable for me if it was formatted this way.
I can make it a setting and allow a toggle if that works for you.
thanks for your feedback. Please do not submit any PR as the frontend is currently being rebuild. I can imagine having a setting for something like this in the future.